fix(pagination): wrap PaginationItem in list and fix hydration error #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correctness Nest each PaginationItem within an unordered list for improved accessibility and to adhere to proper HTML semantics, ensuring that individual pagination buttons are recognized as part of a list structure.
|
@frankdavidcorona is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
frankdavidcorona
changed the title
frankdavidcorona
changed the title
|
@frankdavidcorona We fixed this in #2190. I'm going to close this one but feel free to reopen if you have any questions. Thanks for the PR. Appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each PaginationItem within an unordered list for improved accessibility and to adhere to proper HTML semantics, ensuring that individual pagination buttons are recognized as part of a list structure.
This solve this Hydration issue: