fix(themes): grid falling apart #2418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chaejunlee is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
chaejunlee
changed the title
|
Caught more mistakes and fixed them. AS-IS
TO-BE
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shadcn
requested changes
Jan 14, 2024
There was a problem hiding this comment.
@chaejunlee I'm still seeing a few issues with the grid at 768px. Would you be able to take a look please?
shadcn
added
area: www
postpone: more info or changes requested
|
I thought I have removed them and things work fine. 
|
chaejunlee
changed the title
|
Hello, @shadcn ! Sorry to @ you, but can you please follow up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resizing the Themes, the grid falls apart.
It is due to the fact that
1frofgrid-cols-[260px_1fr]needs to beminmax(0,1fr).And there was a typo in the className as well, which was
grids-col-2.I fixed both of the mistakes.
AS-IS
TO-BE