Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ?? instead of || in <BreadcrumbSeparator> #2941

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fix: use ?? instead of || in <BreadcrumbSeparator> #2941

merged 2 commits into from
Mar 11, 2024

Conversation

kevinmitch14
Copy link
Contributor

If using || and children is falsy, the <ChevronRightIcon /> will render.

In the rare case the something like 0 is passed as children to <BreadcrumbSeparator>, the <ChevronRightIcon /> will render instead of 0

Copy link

vercel bot commented Mar 8, 2024

@kevinmitch14 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 2:10am

Copy link
Contributor

@dan5py dan5py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shadcn shadcn merged commit 3f76d5f into shadcn-ui:main Mar 11, 2024
7 checks passed
Sayakie added a commit to Sayakie/ui that referenced this pull request Mar 13, 2024
Partially cherry-picked from df79ce6
See shadcn-ui#2941
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants