Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 breadcrumb file paths code preview #2946

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

flixlix
Copy link
Contributor

@flixlix flixlix commented Mar 8, 2024

Missing Code in Examples

This PR fixes the issue where some breadcrumb examples were not showing any code preview.

The issue was caused by missing file extensions in the paths to the files.

Before:

image

After:

image

Copy link

vercel bot commented Mar 8, 2024

@flixlix is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@dan5py dan5py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @shadcn

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 0:10am

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you. Appreciate your help on the various fixes @flixlix

@shadcn shadcn merged commit 5ec881d into shadcn-ui:main Mar 13, 2024
7 checks passed
@flixlix flixlix deleted the fix-breadcrumb-code-files branch March 13, 2024 11:19
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants