Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calendar icon components' props not use. #5222

Merged
merged 8 commits into from
Dec 14, 2024

Conversation

laoer536
Copy link
Contributor

@laoer536 laoer536 commented Oct 7, 2024

No description provided.

Copy link

vercel bot commented Oct 7, 2024

@laoer536 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@prajnaprabhu3
Copy link

closes #5225

@prajnaprabhu3
Copy link

you would need to run pnpm run build:registry to update contents of the registry @laoer536

@laoer536
Copy link
Contributor Author

laoer536 commented Oct 8, 2024

you would need to run pnpm run build:registry to update contents of the registry @laoer536

Okay, I have done as you said.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you.

@shadcn shadcn added enhancement New feature or request component: calendar labels Oct 29, 2024
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Dec 14, 2024 11:17am

@shadcn shadcn added the area: roadmap This looks great. We'll add it to the roadmap, review and merge. label Oct 29, 2024
@laoer536
Copy link
Contributor Author

thank you.

All ready, please approve.

# Conflicts:
#	apps/www/public/r/styles/default/calendar.json
#	apps/www/public/r/styles/new-york/calendar.json
#	apps/www/registry/new-york/ui/calendar.tsx
@shadcn shadcn merged commit 102b0b0 into shadcn-ui:main Dec 14, 2024
4 of 5 checks passed
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
* fix: calendar icon components' props not use.

* fix: calendar icon components' props not use.

* style: revert the original className order

* fix: calendar icon components' props not use.

---------

Co-authored-by: shadcn <[email protected]>
@laoer536 laoer536 deleted the fix-calendar branch December 18, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: roadmap This looks great. We'll add it to the roadmap, review and merge. component: calendar enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants