fix(transform): Support aliases that are longer than one character #5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tobbe is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
niktekusho
pushed a commit
to niktekusho/shadcnui
that referenced
this pull request
Nov 21, 2024
…hadcn-ui#5678) * fix(transform): Support aliases that are longer than one character * feat(shadcn): update handling of aliases * chore: add changeset --------- Co-authored-by: shadcn <[email protected]>
2 tasks
Comment on lines
-38
to
+39
| // We fix the alias an return. | ||
| const alias = config.aliases.components.charAt(0) | ||
| // We fix the alias and return. | ||
| const alias = config.aliases.components.split("/")[0] |
There was a problem hiding this comment.
This change has caused a regression where the import of cn is messed up in monorepos.
It results in
import { cn } from "@my-custom-repo/lib/utils"instead of
import { cn } from "@my-custom-repo/ui/lib/utils"Although it works fine for the default initialized workspace - @workspace/ui/lib/utils
CC: @shadcn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to add a component generated by v0 I noticed that my import aliases were wrong. This PR fixes that for me.
This is the json that v0 gave me
{ "name": "b_5IaISTjKuul", "type": "registry:block", "dependencies": [], "devDependencies": [], "registryDependencies": [], "files": [ { "path": "components/app-architecture-accessibility-page.tsx", "type": "registry:block", "content": "'use client'\n\nimport DocLayout from \"@/components/doc-layout\"\n\nexport function Page() {\n return (\n \u003CDocLayout title=\"Accessibility\" section=\"Architecture\"\u003E\n \u003Cp\u003EThis is the accessibility page. Add your content about accessibility features here.\u003C/p\u003E\n \u003C/DocLayout\u003E\n )\n}" } ], "tailwind": { }, "cssVars": { }, "meta": { "importSpecifier": "Page", "moduleSpecifier": "@/components/app-architecture-accessibility-page" }, "docs": "Please review v0-generated code before incorporating it into your project to ensure completeness and accuracy." }Without fix:
import DocLayout from "@/components/doc-layout"With fix:
import DocLayout from "@shad/components/doc-layout"