Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button-group): add new component #570

Closed
wants to merge 2 commits into from
Closed

Conversation

filipjnc
Copy link

@filipjnc filipjnc commented Jun 11, 2023

I created a new button group component that uses @radix-ui/react-radio-group but looks like the tabs list + triggers components:
image

Check it out at:
http://localhost:3001/docs/components/button-group or http://localhost:3001/sink

I use it for use cases like this:
image

@vercel
Copy link

vercel bot commented Jun 11, 2023

@filipjnc is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@statusunknown418
Copy link

plans on merging this?

@statusunknown418
Copy link

this is really useful, although I found a bug that wherever the component is used, it forces a reload when the parent comp is updated

@Cerfio
Copy link

Cerfio commented Aug 21, 2023

Works perfectly, thank you for your work 🎉 !

@SaadBazaz
Copy link

This looks nice, but do you think @radix-ui/react-toggle-group could work as a baseline?

@shadcn
Copy link
Collaborator

shadcn commented Nov 12, 2023

@filipjnc I've merged a PR for toggle group which should cover this here. #1547.

I'm going to mark this PR as closed but feel free to reopen if you think toggle group does not cover all the cases and we still need a button group component.

Thanks for your help. Appreciate it!

@shadcn shadcn closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants