-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Slang-RHI to get recent WGPU fixes #5467
Conversation
8418f83
to
46adbc5
Compare
It feels like the new slang-rhi brought in some incompatible dxc compiler. |
I'll check if
|
46adbc5
to
91d4f94
Compare
I'm adding a change that allows to disable fetching dxc and Agility SDK -> shader-slang/slang-rhi#90 When that is merged, you can just set the following before set(SLANG_RHI_FETCH_DXC OFF)
set(SLANG_RHI_FETCH_AGILITY_SDK OFF) |
That said, we should probably check why the latest dxc version fails to compile those shaders ... |
I filed #5474 for this |
This helps to address issue shader-slang#5222. Also disable Slang-RHI from fetching DXC and Agility SDK, since that seems to break our tests. (See issue shader-slang#5474.)
91d4f94
to
cc81f27
Compare
Yep, tests are passing when doing this and still pointing to RHI main ToT. |
No description provided.