Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slang-RHI to get recent WGPU fixes #5467

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

aleino-nv
Copy link
Collaborator

No description provided.

@aleino-nv aleino-nv added the pr: non-breaking PRs without breaking changes label Oct 31, 2024
csyonghe
csyonghe previously approved these changes Oct 31, 2024
@csyonghe
Copy link
Collaborator

It feels like the new slang-rhi brought in some incompatible dxc compiler.

@aleino-nv
Copy link
Collaborator Author

It feels like the new slang-rhi brought in some incompatible dxc compiler.

I'll check if 801865f is the culprit.

$ git log --oneline  ebc2b53ee9a06b73e26fa7ca6d2ee30fcf53b6d7..main
edb9b72 (HEAD, origin/main, origin/HEAD, main) Add missing WGPU device tick after async map (#89)
262d7a8 Add missing call to add descriptor ranges as constant buffer (#88)
ad87777 fix string::format
6386188 move acceleration structure utils (#86)
801865f fetch dxc & agility sdk (#85)
b322abb enable ci for aarch64 (#84)

@skallweitNV
Copy link
Collaborator

I'm adding a change that allows to disable fetching dxc and Agility SDK -> shader-slang/slang-rhi#90

When that is merged, you can just set the following before add_subdirectory(slang-rhi):

set(SLANG_RHI_FETCH_DXC OFF)
set(SLANG_RHI_FETCH_AGILITY_SDK OFF)

@skallweitNV
Copy link
Collaborator

That said, we should probably check why the latest dxc version fails to compile those shaders ...

@aleino-nv
Copy link
Collaborator Author

That said, we should probably check why the latest dxc version fails to compile those shaders ...

I filed #5474 for this

This helps to address issue shader-slang#5222.

Also disable Slang-RHI from fetching DXC and Agility SDK, since that seems to break our
tests. (See issue shader-slang#5474.)
@aleino-nv
Copy link
Collaborator Author

I'm adding a change that allows to disable fetching dxc and Agility SDK -> shader-slang/slang-rhi#90

When that is merged, you can just set the following before add_subdirectory(slang-rhi):

set(SLANG_RHI_FETCH_DXC OFF)
set(SLANG_RHI_FETCH_AGILITY_SDK OFF)

Yep, tests are passing when doing this and still pointing to RHI main ToT.
Please have a look and approve if the CMake changes look fine.

@aleino-nv aleino-nv requested a review from csyonghe November 1, 2024 09:57
@aleino-nv aleino-nv merged commit c044ec2 into shader-slang:master Nov 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants