Deduplicate witness table while specializing generic functions #6363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwak-work
force-pushed
the
fix/duplicated_struct_for_DiffPair
branch
from
30a393e to
fa32e98
Compare
jkwak-work
changed the title
csyonghe
reviewed
Feb 14, 2025
|
I created an issue for this PR: |
jkwak-work
force-pushed
the
fix/duplicated_struct_for_DiffPair
branch
from
fa32e98 to
0ba6c28
Compare
jkwak-work
changed the title
|
The latest change on this PR removes the duplicated witness table while specializing the generics. |
csyonghe
reviewed
Feb 15, 2025
jkwak-work
force-pushed
the
fix/duplicated_struct_for_DiffPair
branch
from
9cd57c5 to
f9f9ea7
Compare
|
I made changes as suggested. |
|
From a quick inspection with LLM, it appears that the decorations need to be handled properly. |
This commit is to experiment the idea of what would happen if we deduplicate the witness table based only on its type and its first operand. It turned out that it causes a crash, because it doesn't carry the decorations and childs properly. It means we need to also consider them as well as its type and its first operand. But if we do, we cannot deduplicate anything. It seems that this is not the right place to apply the deduplication.
jkwak-work
force-pushed
the
fix/duplicated_struct_for_DiffPair
branch
from
31829d4 to
9dbbcdf
Compare
|
It appears the the witness-table-entry as the children are same when the type and concrete type are same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue that Slang sometimes emits duplicated DiffPair_XX structs when targeting HLSL.
This fix is required for upgrading DXC version from 1.7 to 1.9. With DXC 1.7, it had been fine even with the duplicated structs as long as their member variables are identical. But with DXC 1.9, it causes a compile error.
Closes #6364