-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for dynamic array of textures access for Texture footprint. #6392
Support for dynamic array of textures access for Texture footprint. #6392
Conversation
|
/format |
🌈 Formatted, please merge the changes from this PR |
@csyonghe , as discussed on our meeting last week, can you review the change and decide if we want to have the change or drop it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when you run the test without the code change?
I am getting a compile error like the following when targeting HLSL/DXIL,
But it seems like targeting SPIRV is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is fine to merge this in, even if it is a partial solution.
This is PR implemented by jsmall on Oct 2023. The change is old and it is unclear if we still need this code or not.
We need to decide if we want to merge or drop.
Note that the source code comment stated that the implementation is "hack".