Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dynamic array of textures access for Texture footprint. #6392

Conversation

jkwak-work
Copy link
Collaborator

@jkwak-work jkwak-work commented Feb 18, 2025

This is PR implemented by jsmall on Oct 2023. The change is old and it is unclear if we still need this code or not.

We need to decide if we want to merge or drop.

Note that the source code comment stated that the implementation is "hack".

// TODO(JS): This a hack to make this work for arrays of resource type.

@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Feb 18, 2025
@jkwak-work jkwak-work self-assigned this Feb 18, 2025
@jkwak-work jkwak-work requested a review from a team as a code owner February 18, 2025 22:54
@CLAassistant
Copy link

CLAassistant commented Feb 18, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ slangbot
✅ csyonghe
❌ jsmall-zzz
You have signed the CLA already but the status is still pending? Let us recheck it.

@jkwak-work
Copy link
Collaborator Author

/format

@slangbot
Copy link
Contributor

🌈 Formatted, please merge the changes from this PR

@jkwak-work
Copy link
Collaborator Author

@csyonghe , as discussed on our meeting last week, can you review the change and decide if we want to have the change or drop it?

Copy link
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you run the test without the code change?

@jkwak-work
Copy link
Collaborator Author

What happens when you run the test without the code change?

I am getting a compile error like the following when targeting HLSL/DXIL,

$ slangc.exe -target hlsl -entry fragmentMain -stage fragment tests/tmp.slang

tests/tmp.slang(59): error 81111: could not determine register/space for a resource or sampler used with NVAPI
void fragmentMain(
     ^~~~~~~~~~~~

But it seems like targeting SPIRV is fine.

Copy link
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is fine to merge this in, even if it is a partial solution.

@csyonghe csyonghe merged commit 187ec44 into shader-slang:master Feb 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants