Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hand_commander failing tests because of upper case joint names convention #40

Open
AndriyPt opened this issue Oct 29, 2015 · 2 comments
Open

hand_commander failing tests because of upper case joint names convention #40

AndriyPt opened this issue Oct 29, 2015 · 2 comments
Assignees
@AndriyPt
Labels
bug in progress

Comments

@AndriyPt
Copy link
Contributor

This comment https://github.com/shadow-robot/sr_core/blob/indigo-devel/sr_hand/src/hand_commander.cpp#L219 seems to be not true anymore. Which cause some of the task failures.
@AndriyPt AndriyPt added the bug label Oct 29, 2015
@toliver
Copy link
Contributor

toliver commented Oct 29, 2015

The proposed fix (removing boost::algorithm::to_upper(joint_name)) might be enough.
It is worth first checking where is the HandCommander used currently, to see if we should delete it.

@AndriyPt
Copy link
Contributor Author

search through public repositories in GitHub shows only our packages https://github.com/search?utf8=%E2%9C%93&q=sr_hand%2Fhand_commander.hpp&type=Code&ref=searchresults

@AndriyPt AndriyPt self-assigned this Oct 30, 2015
@toliver toliver mentioned this issue Mar 17, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndriyPt AndriyPt

Labels
bug in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toliver @AndriyPt