Skip to content

chore(homebrew): v1.16.2 new release #627

chore(homebrew): v1.16.2 new release

chore(homebrew): v1.16.2 new release #627

Triggered via push September 23, 2023 07:27
Status Failure
Total duration 50s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

clippy-check.yml

on: push
Matrix: clippy-check
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 5 warnings
expected a `std::ops::FnOnce<()>` closure, found `{integer}`: crates/shadowsocks-service/src/local/mod.rs#L356
error[E0277]: expected a `std::ops::FnOnce<()>` closure, found `{integer}` --> crates/shadowsocks-service/src/local/mod.rs:356:95 | 356 | let client_cache_size = local_config.client_cache_size.unwrap_or_else(5); | -------------- ^ expected an `FnOnce<()>` closure, found `{integer}` | | | required by a bound introduced by this call | = help: the trait `std::ops::FnOnce<()>` is not implemented for `{integer}` = note: wrap the `{integer}` in a closure with no arguments: `|| { /* code */ }` note: required by a bound in `std::option::Option::<T>::unwrap_or_else` --> /rustc/e4133ba9b1a150ef624f5d189913a37405f4414c/library/core/src/option.rs:973:5
no field `client_cache_size` on type `config::SSLocalExtConfig`: crates/shadowsocks-service/src/config.rs#L1558
error[E0609]: no field `client_cache_size` on type `config::SSLocalExtConfig` --> crates/shadowsocks-service/src/config.rs:1558:68 | 1558 | ... local_config.client_cache_size = local.client_cache_size; | ^^^^^^^^^^^^^^^^^ unknown field | = note: available fields are: `local_address`, `local_port`, `disabled`, `mode`, `local_udp_address` ... and 12 others
struct `config::SSLocalExtConfig` has no field named `client_cache_size`: crates/shadowsocks-service/src/config.rs#L2473
error[E0560]: struct `config::SSLocalExtConfig` has no field named `client_cache_size` --> crates/shadowsocks-service/src/config.rs:2473:25 | 2473 | client_cache_size: local.client_cache_size.clone(), | ^^^^^^^^^^^^^^^^^ `config::SSLocalExtConfig` does not have this field | = note: all struct fields are already assigned
clippy-check (ubuntu-latest)
Clippy had exited with the 101 exit code
clippy-check (macos-latest)
The job was canceled because "ubuntu-latest" failed.
clippy-check (macos-latest)
The operation was canceled.
clippy-check (windows-latest)
The job was canceled because "ubuntu-latest" failed.
clippy-check (windows-latest)
The operation was canceled.
this argument is a mutable reference, but not used mutably: crates/shadowsocks/src/net/sys/unix/uds.rs#L71
warning: this argument is a mutable reference, but not used mutably --> crates/shadowsocks/src/net/sys/unix/uds.rs:71:47 | 71 | pub async fn recv_with_fd(&mut self, buf: &mut [u8], fds: &mut [RawFd]) -> io::Result<(usize, usize)> { | ^^^^^^^^^ help: consider changing to: `&[u8]` | = warning: changing this function will impact semver compatibility = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut = note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default
this argument is a mutable reference, but not used mutably: crates/shadowsocks/src/net/sys/unix/uds.rs#L71
warning: this argument is a mutable reference, but not used mutably --> crates/shadowsocks/src/net/sys/unix/uds.rs:71:63 | 71 | pub async fn recv_with_fd(&mut self, buf: &mut [u8], fds: &mut [RawFd]) -> io::Result<(usize, usize)> { | ^^^^^^^^^^^^ help: consider changing to: `&[RawFd]` | = warning: changing this function will impact semver compatibility = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
this argument is a mutable reference, but not used mutably: crates/shadowsocks/src/net/udp.rs#L191
warning: this argument is a mutable reference, but not used mutably --> crates/shadowsocks/src/net/udp.rs:191:42 | 191 | pub async fn batch_send(&self, msgs: &mut [BatchSendMessage<'_>]) -> io::Result<usize> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&[BatchSendMessage<'_>]` | = warning: changing this function will impact semver compatibility = note: this is cfg-gated and may require further changes = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
this argument is a mutable reference, but not used mutably: crates/shadowsocks/src/net/udp.rs#L229
warning: this argument is a mutable reference, but not used mutably --> crates/shadowsocks/src/net/udp.rs:229:42 | 229 | pub async fn batch_recv(&self, msgs: &mut [BatchRecvMessage<'_>]) -> io::Result<usize> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&[BatchRecvMessage<'_>]` | = warning: changing this function will impact semver compatibility = note: this is cfg-gated and may require further changes = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
unnecessary hashes around raw string literal: crates/shadowsocks-service/src/acl/mod.rs#L195
warning: unnecessary hashes around raw string literal --> crates/shadowsocks-service/src/acl/mod.rs:195:17 | 195 | r#"^(?:(?:\((?:\?:)?\^\|\\\.\)|(?:\^\.(?:\+|\*))?\\\.)((?:[\w-]+(?:\\\.)?)+)|\^((?:[\w-]+(?:\\\.)?)+))\$?$"#, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes = note: `#[warn(clippy::needless_raw_string_hashes)]` on by default help: remove all the hashes around the literal | 195 - r#"^(?:(?:\((?:\?:)?\^\|\\\.\)|(?:\^\.(?:\+|\*))?\\\.)((?:[\w-]+(?:\\\.)?)+)|\^((?:[\w-]+(?:\\\.)?)+))\$?$"#, 195 + r"^(?:(?:\((?:\?:)?\^\|\\\.\)|(?:\^\.(?:\+|\*))?\\\.)((?:[\w-]+(?:\\\.)?)+)|\^((?:[\w-]+(?:\\\.)?)+))\$?$", |