bugfix: fix missed client_cache_size config item in SSLocalExtConfig #643
Annotations
9 warnings
the borrowed expression implements the required traits:
crates/shadowsocks/src/config.rs#L636
warning: the borrowed expression implements the required traits
--> crates/shadowsocks/src/config.rs:636:55
|
636 | URL_PASSWORD_BASE64_ENGINE.encode(&user_info)
| ^^^^^^^^^^ help: change this to: `user_info`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
using `clone` on type `Option<usize>` which implements the `Copy` trait:
crates/shadowsocks-service/src/config.rs#L2469
warning: using `clone` on type `Option<usize>` which implements the `Copy` trait
--> crates/shadowsocks-service/src/config.rs:2469:44
|
2469 | client_cache_size: local.client_cache_size.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `local.client_cache_size`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
this OR pattern can be rewritten using a range:
src/logging/mod.rs#L58
warning: this OR pattern can be rewritten using a range
--> src/logging/mod.rs:58:9
|
58 | 0 | 1 | 2 | 3 => logging_builder
| ^^^^^^^^^^^^^ help: try: `0..=3`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns
= note: `#[warn(clippy::manual_range_patterns)]` on by default
|
useless conversion to the same type: `u32`:
src/sys.rs#L124
warning: useless conversion to the same type: `u32`
--> src/sys.rs:124:42
|
124 | if libc::initgroups(pwd.pw_name, pwd.pw_gid.try_into().unwrap()) != 0 {
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
unneeded `return` statement:
bin/ssurl.rs#L161
warning: unneeded `return` statement
--> bin/ssurl.rs:161:5
|
161 | return ExitCode::FAILURE;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
161 - return ExitCode::FAILURE;
161 + ExitCode::FAILURE
|
|
the borrowed expression implements the required traits:
crates/shadowsocks/src/config.rs#L636
warning: the borrowed expression implements the required traits
--> crates/shadowsocks/src/config.rs:636:55
|
636 | URL_PASSWORD_BASE64_ENGINE.encode(&user_info)
| ^^^^^^^^^^ help: change this to: `user_info`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
using `clone` on type `Option<usize>` which implements the `Copy` trait:
crates/shadowsocks-service/src/config.rs#L2469
warning: using `clone` on type `Option<usize>` which implements the `Copy` trait
--> crates/shadowsocks-service/src/config.rs:2469:44
|
2469 | client_cache_size: local.client_cache_size.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `local.client_cache_size`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
this OR pattern can be rewritten using a range:
src/logging/mod.rs#L58
warning: this OR pattern can be rewritten using a range
--> src/logging/mod.rs:58:9
|
58 | 0 | 1 | 2 | 3 => logging_builder
| ^^^^^^^^^^^^^ help: try: `0..=3`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns
= note: `#[warn(clippy::manual_range_patterns)]` on by default
|
unneeded `return` statement:
bin/ssurl.rs#L161
warning: unneeded `return` statement
--> bin/ssurl.rs:161:5
|
161 | return ExitCode::FAILURE;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
161 - return ExitCode::FAILURE;
161 + ExitCode::FAILURE
|
|