chore(deps): bump clap from 4.4.13 to 4.4.18 #856
Annotations
11 warnings
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Clippy Check:
crates/shadowsocks/src/config.rs#L636
warning: the borrowed expression implements the required traits
--> crates/shadowsocks/src/config.rs:636:55
|
636 | URL_PASSWORD_BASE64_ENGINE.encode(&user_info)
| ^^^^^^^^^^ help: change this to: `user_info`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
Clippy Check:
crates/shadowsocks/src/net/udp.rs#L207
warning: useless conversion to the same type: `std::result::Result<usize, std::io::Error>`
--> crates/shadowsocks/src/net/udp.rs:207:24
|
207 | return Err(make_mtu_error(buf.len(), mtu)).into();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Err(make_mtu_error(buf.len(), mtu))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
Clippy Check:
crates/shadowsocks/src/net/udp.rs#L232
warning: useless conversion to the same type: `std::result::Result<usize, std::io::Error>`
--> crates/shadowsocks/src/net/udp.rs:232:24
|
232 | return Err(make_mtu_error(buf.len(), mtu)).into();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Err(make_mtu_error(buf.len(), mtu))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
Clippy Check:
crates/shadowsocks-service/src/local/redir/tcprelay/sys/unix/mod.rs#L13
warning: unused import: `self::bsd::*`
--> crates/shadowsocks-service/src/local/redir/tcprelay/sys/unix/mod.rs:13:17
|
13 | pub use self::bsd::*;
| ^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
Clippy Check:
crates/shadowsocks-service/src/local/redir/tcprelay/sys/mod.rs#L6
warning: unused import: `self::unix::*`
--> crates/shadowsocks-service/src/local/redir/tcprelay/sys/mod.rs:6:17
|
6 | pub use self::unix::*;
| ^^^^^^^^^^^^^
|
Clippy Check:
crates/shadowsocks-service/src/local/http/http_client.rs#L42
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates/shadowsocks-service/src/local/http/http_client.rs:42:17
|
42 | cache_conn: Arc<Mutex<LruCache<Address, VecDeque<(HttpConnection, Instant)>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
Clippy Check:
crates/shadowsocks-service/src/local/http/http_client.rs#L99
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/shadowsocks-service/src/local/http/http_client.rs:99:63
|
99 | if let Some(q) = self.cache_conn.lock().await.get_mut(&host) {
| ^^^^^ help: change this to: `host`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
Clippy Check:
crates/shadowsocks-service/src/manager/server.rs#L420
warning: file opened with `create`, but `truncate` behavior not defined
--> crates/shadowsocks-service/src/manager/server.rs:420:46
|
420 | match OpenOptions::new().write(true).create(true).open(&config_file_path) {
| ^^^^^^^^^^^^- help: add: `.truncate(true)`
|
= help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
= help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
= help: alternatively, use `.append(true)` to append to the file instead of overwriting it
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
= note: `#[warn(clippy::suspicious_open_options)]` on by default
|
Clippy Check:
crates/shadowsocks-service/src/sys/unix/macos.rs#L62
warning: use of `offset` with a `usize` casted to an `isize`
--> crates/shadowsocks-service/src/sys/unix/macos.rs:62:27
|
62 | let fd = *(fds.offset(idx as isize));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fds.add(idx)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
= note: `#[warn(clippy::ptr_offset_with_cast)]` on by default
|
Clippy Check:
src/logging/mod.rs#L58
warning: this OR pattern can be rewritten using a range
--> src/logging/mod.rs:58:9
|
58 | 0 | 1 | 2 | 3 => logging_builder
| ^^^^^^^^^^^^^ help: try: `0..=3`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns
= note: `#[warn(clippy::manual_range_patterns)]` on by default
|
The logs for this run have expired and are no longer available.
Loading