Fix per-server outbound options not taking effect (part 2) #1059
Annotations
10 warnings
Clippy Check:
crates/shadowsocks/src/relay/tcprelay/aead.rs#L40
warning: importing legacy numeric constants
--> crates/shadowsocks/src/relay/tcprelay/aead.rs:40:5
|
40 | u16,
| ^^^
|
= help: remove this import
= note: then `u16::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
|
Clippy Check:
crates/shadowsocks/src/relay/tcprelay/aead_2022.rs#L54
warning: importing legacy numeric constants
--> crates/shadowsocks/src/relay/tcprelay/aead_2022.rs:54:5
|
54 | u16,
| ^^^
|
= help: remove this import
= note: then `u16::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L1891
warning: redundant field names in struct initialization
--> crates/shadowsocks-service/src/config.rs:1891:21
|
1891 | outbound_bind_addr: outbound_bind_addr,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbound_bind_addr`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L2073
warning: redundant field names in struct initialization
--> crates/shadowsocks-service/src/config.rs:2073:21
|
2073 | outbound_bind_addr: outbound_bind_addr,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbound_bind_addr`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L1531
warning: assigning the result of `Clone::clone()` may be inefficient
--> crates/shadowsocks-service/src/config.rs:1531:25
|
1531 | local_config.launchd_tcp_socket_name = config.launchd_tcp_socket_name.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `local_config.launchd_tcp_socket_name.clone_from(&config.launchd_tcp_socket_name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L1532
warning: assigning the result of `Clone::clone()` may be inefficient
--> crates/shadowsocks-service/src/config.rs:1532:25
|
1532 | local_config.launchd_udp_socket_name = config.launchd_udp_socket_name.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `local_config.launchd_udp_socket_name.clone_from(&config.launchd_udp_socket_name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L2616
warning: assigning the result of `Clone::clone()` may be inefficient
--> crates/shadowsocks-service/src/config.rs:2616:21
|
2616 | jconf.launchd_tcp_socket_name = local.launchd_tcp_socket_name.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `jconf.launchd_tcp_socket_name.clone_from(&local.launchd_tcp_socket_name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L2617
warning: assigning the result of `Clone::clone()` may be inefficient
--> crates/shadowsocks-service/src/config.rs:2617:21
|
2617 | jconf.launchd_udp_socket_name = local.launchd_udp_socket_name.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `jconf.launchd_udp_socket_name.clone_from(&local.launchd_udp_socket_name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L2879
warning: using `clone` on type `Option<IpAddr>` which implements the `Copy` trait
--> crates/shadowsocks-service/src/config.rs:2879:45
|
2879 | outbound_bind_addr: inst.outbound_bind_addr.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `inst.outbound_bind_addr`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L2984
warning: assigning the result of `Clone::clone()` may be inefficient
--> crates/shadowsocks-service/src/config.rs:2984:9
|
2984 | jconf.outbound_bind_interface = self.outbound_bind_interface.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `jconf.outbound_bind_interface.clone_from(&self.outbound_bind_interface)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
Loading