Fix per-server outbound options not taking effect (part 2) #1060
Annotations
7 warnings
Clippy Check:
crates/shadowsocks/src/relay/tcprelay/aead.rs#L40
warning: importing legacy numeric constants
--> crates/shadowsocks/src/relay/tcprelay/aead.rs:40:5
|
40 | u16,
| ^^^
|
= help: remove this import
= note: then `u16::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
|
Clippy Check:
crates/shadowsocks/src/relay/tcprelay/aead_2022.rs#L54
warning: importing legacy numeric constants
--> crates/shadowsocks/src/relay/tcprelay/aead_2022.rs:54:5
|
54 | u16,
| ^^^
|
= help: remove this import
= note: then `u16::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L1891
warning: redundant field names in struct initialization
--> crates/shadowsocks-service/src/config.rs:1891:21
|
1891 | outbound_bind_addr: outbound_bind_addr,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbound_bind_addr`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L2878
warning: using `clone` on type `Option<u32>` which implements the `Copy` trait
--> crates/shadowsocks-service/src/config.rs:2878:42
|
2878 | outbound_fwmark: inst.outbound_fwmark.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `inst.outbound_fwmark`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
Clippy Check:
crates/shadowsocks-service/src/config.rs#L2984
warning: assigning the result of `Clone::clone()` may be inefficient
--> crates/shadowsocks-service/src/config.rs:2984:9
|
2984 | jconf.outbound_bind_interface = self.outbound_bind_interface.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `jconf.outbound_bind_interface.clone_from(&self.outbound_bind_interface)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
Clippy Check:
crates/shadowsocks-service/src/server/udprelay.rs#L651
warning: assigning the result of `Clone::clone()` may be inefficient
--> crates/shadowsocks-service/src/server/udprelay.rs:651:13
|
651 | session_context.client_user = control.user.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `session_context.client_user.clone_from(&control.user)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
Clippy Check:
crates/shadowsocks-service/src/server/udprelay.rs#L825
warning: assigning the result of `Clone::clone()` may be inefficient
--> crates/shadowsocks-service/src/server/udprelay.rs:825:17
|
825 | control.user = client_session.client_user.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `control.user.clone_from(&client_session.client_user)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
Loading