Skip to content

Fix per-server outbound options not taking effect (part 2) #1062

Fix per-server outbound options not taking effect (part 2)

Fix per-server outbound options not taking effect (part 2) #1062

Triggered via pull request April 14, 2024 15:20
Status Success
Total duration 2m 40s
Artifacts

clippy-check.yml

on: pull_request
Matrix: clippy-check
Fit to window
Zoom out
Zoom in

Annotations

14 warnings
importing legacy numeric constants: crates/shadowsocks/src/relay/tcprelay/aead.rs#L40
warning: importing legacy numeric constants --> crates/shadowsocks/src/relay/tcprelay/aead.rs:40:5 | 40 | u16, | ^^^ | = help: remove this import = note: then `u16::<CONST>` will resolve to the respective associated constant = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
importing legacy numeric constants: crates/shadowsocks/src/relay/tcprelay/aead_2022.rs#L54
warning: importing legacy numeric constants --> crates/shadowsocks/src/relay/tcprelay/aead_2022.rs:54:5 | 54 | u16, | ^^^ | = help: remove this import = note: then `u16::<CONST>` will resolve to the respective associated constant = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
assigning the result of `Clone::clone()` may be inefficient: crates/shadowsocks-service/src/config.rs#L2984
warning: assigning the result of `Clone::clone()` may be inefficient --> crates/shadowsocks-service/src/config.rs:2984:9 | 2984 | jconf.outbound_bind_interface = self.outbound_bind_interface.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `jconf.outbound_bind_interface.clone_from(&self.outbound_bind_interface)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default
assigning the result of `Clone::clone()` may be inefficient: crates/shadowsocks-service/src/server/udprelay.rs#L651
warning: assigning the result of `Clone::clone()` may be inefficient --> crates/shadowsocks-service/src/server/udprelay.rs:651:13 | 651 | session_context.client_user = control.user.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `session_context.client_user.clone_from(&control.user)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
assigning the result of `Clone::clone()` may be inefficient: crates/shadowsocks-service/src/server/udprelay.rs#L825
warning: assigning the result of `Clone::clone()` may be inefficient --> crates/shadowsocks-service/src/server/udprelay.rs:825:17 | 825 | control.user = client_session.client_user.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `control.user.clone_from(&client_session.client_user)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
importing legacy numeric constants: crates/shadowsocks/src/relay/tcprelay/aead.rs#L40
warning: importing legacy numeric constants --> crates/shadowsocks/src/relay/tcprelay/aead.rs:40:5 | 40 | u16, | ^^^ | = help: remove this import = note: then `u16::<CONST>` will resolve to the respective associated constant = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
importing legacy numeric constants: crates/shadowsocks/src/relay/tcprelay/aead_2022.rs#L54
warning: importing legacy numeric constants --> crates/shadowsocks/src/relay/tcprelay/aead_2022.rs:54:5 | 54 | u16, | ^^^ | = help: remove this import = note: then `u16::<CONST>` will resolve to the respective associated constant = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
assigning the result of `Clone::clone()` may be inefficient: crates/shadowsocks-service/src/config.rs#L1531
warning: assigning the result of `Clone::clone()` may be inefficient --> crates/shadowsocks-service/src/config.rs:1531:25 | 1531 | local_config.launchd_tcp_socket_name = config.launchd_tcp_socket_name.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `local_config.launchd_tcp_socket_name.clone_from(&config.launchd_tcp_socket_name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default
assigning the result of `Clone::clone()` may be inefficient: crates/shadowsocks-service/src/config.rs#L1532
warning: assigning the result of `Clone::clone()` may be inefficient --> crates/shadowsocks-service/src/config.rs:1532:25 | 1532 | local_config.launchd_udp_socket_name = config.launchd_udp_socket_name.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `local_config.launchd_udp_socket_name.clone_from(&config.launchd_udp_socket_name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
assigning the result of `Clone::clone()` may be inefficient: crates/shadowsocks-service/src/config.rs#L2616
warning: assigning the result of `Clone::clone()` may be inefficient --> crates/shadowsocks-service/src/config.rs:2616:21 | 2616 | jconf.launchd_tcp_socket_name = local.launchd_tcp_socket_name.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `jconf.launchd_tcp_socket_name.clone_from(&local.launchd_tcp_socket_name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
assigning the result of `Clone::clone()` may be inefficient: crates/shadowsocks-service/src/config.rs#L2617
warning: assigning the result of `Clone::clone()` may be inefficient --> crates/shadowsocks-service/src/config.rs:2617:21 | 2617 | jconf.launchd_udp_socket_name = local.launchd_udp_socket_name.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `jconf.launchd_udp_socket_name.clone_from(&local.launchd_udp_socket_name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
assigning the result of `Clone::clone()` may be inefficient: crates/shadowsocks-service/src/config.rs#L2984
warning: assigning the result of `Clone::clone()` may be inefficient --> crates/shadowsocks-service/src/config.rs:2984:9 | 2984 | jconf.outbound_bind_interface = self.outbound_bind_interface.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `jconf.outbound_bind_interface.clone_from(&self.outbound_bind_interface)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
assigning the result of `Clone::clone()` may be inefficient: crates/shadowsocks-service/src/server/udprelay.rs#L651
warning: assigning the result of `Clone::clone()` may be inefficient --> crates/shadowsocks-service/src/server/udprelay.rs:651:13 | 651 | session_context.client_user = control.user.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `session_context.client_user.clone_from(&control.user)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
assigning the result of `Clone::clone()` may be inefficient: crates/shadowsocks-service/src/server/udprelay.rs#L825
warning: assigning the result of `Clone::clone()` may be inefficient --> crates/shadowsocks-service/src/server/udprelay.rs:825:17 | 825 | control.user = client_session.client_user.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `control.user.clone_from(&client_session.client_user)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones