Skip to content

fix(local-online-build): fix online_config missing in default build #1110

fix(local-online-build): fix online_config missing in default build

fix(local-online-build): fix online_config missing in default build #1110

Triggered via push June 11, 2024 18:20
Status Success
Total duration 12m 31s
Artifacts 5
Matrix: build-cross
Matrix: build-unix
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
useless conversion to the same type: `std::io::Error`: crates/shadowsocks-service/src/local/online_config/mod.rs#L186
warning: useless conversion to the same type: `std::io::Error` --> crates/shadowsocks-service/src/local/online_config/mod.rs:186:24 | 186 | return Err(io::Error::new(io::ErrorKind::Other, err).into()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::new(io::ErrorKind::Other, err)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `std::io::Error`: crates/shadowsocks-service/src/local/online_config/mod.rs#L177
warning: useless conversion to the same type: `std::io::Error` --> crates/shadowsocks-service/src/local/online_config/mod.rs:177:28 | 177 | return Err(io::Error::new(io::ErrorKind::Other, err).into()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::new(io::ErrorKind::Other, err)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `std::io::Error`: crates/shadowsocks-service/src/local/online_config/mod.rs#L167
warning: useless conversion to the same type: `std::io::Error` --> crates/shadowsocks-service/src/local/online_config/mod.rs:167:35 | 167 | Err(..) => return Err(io::Error::new(io::ErrorKind::Other, "body contains non-utf8 bytes").into()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::new(io::ErrorKind::Other, "body contains non-utf8 bytes")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
you should consider adding a `Default` implementation for `HttpClient<B>`: crates/shadowsocks-service/src/local/http/http_client.rs#L115
warning: you should consider adding a `Default` implementation for `HttpClient<B>` --> crates/shadowsocks-service/src/local/http/http_client.rs:115:5 | 115 | / pub fn new() -> HttpClient<B> { 116 | | HttpClient { 117 | | cache_conn: Arc::new(Mutex::new(LruCache::with_expiry_duration(CONNECTION_EXPIRE_DURATION))), 118 | | } 119 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 108 + impl<B> Default for HttpClient<B> 109 + where 110 + B: Body + Send + Unpin + Debug + 'static, 111 + B::Data: Send, 112 + B::Error: Into<Box<dyn ::std::error::Error + Send + Sync>>, 113 + { 114 + fn default() -> Self { 115 + Self::new() 116 + } 117 + } |
useless conversion to the same type: `std::time::Instant`: crates/shadowsocks-service/src/local/http/http_client.rs#L67
warning: useless conversion to the same type: `std::time::Instant` --> crates/shadowsocks-service/src/local/http/http_client.rs:67:25 | 67 | sleep.reset(new_deadline.into()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `new_deadline` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
useless conversion to the same type: `std::io::Error`: crates/shadowsocks-service/src/local/online_config/mod.rs#L186
warning: useless conversion to the same type: `std::io::Error` --> crates/shadowsocks-service/src/local/online_config/mod.rs:186:24 | 186 | return Err(io::Error::new(io::ErrorKind::Other, err).into()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::new(io::ErrorKind::Other, err)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `std::io::Error`: crates/shadowsocks-service/src/local/online_config/mod.rs#L177
warning: useless conversion to the same type: `std::io::Error` --> crates/shadowsocks-service/src/local/online_config/mod.rs:177:28 | 177 | return Err(io::Error::new(io::ErrorKind::Other, err).into()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::new(io::ErrorKind::Other, err)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `std::io::Error`: crates/shadowsocks-service/src/local/online_config/mod.rs#L167
warning: useless conversion to the same type: `std::io::Error` --> crates/shadowsocks-service/src/local/online_config/mod.rs:167:35 | 167 | Err(..) => return Err(io::Error::new(io::ErrorKind::Other, "body contains non-utf8 bytes").into()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::new(io::ErrorKind::Other, "body contains non-utf8 bytes")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
you should consider adding a `Default` implementation for `HttpClient<B>`: crates/shadowsocks-service/src/local/http/http_client.rs#L115
warning: you should consider adding a `Default` implementation for `HttpClient<B>` --> crates/shadowsocks-service/src/local/http/http_client.rs:115:5 | 115 | / pub fn new() -> HttpClient<B> { 116 | | HttpClient { 117 | | cache_conn: Arc::new(Mutex::new(LruCache::with_expiry_duration(CONNECTION_EXPIRE_DURATION))), 118 | | } 119 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 108 + impl<B> Default for HttpClient<B> 109 + where 110 + B: Body + Send + Unpin + Debug + 'static, 111 + B::Data: Send, 112 + B::Error: Into<Box<dyn ::std::error::Error + Send + Sync>>, 113 + { 114 + fn default() -> Self { 115 + Self::new() 116 + } 117 + } |
useless conversion to the same type: `std::time::Instant`: crates/shadowsocks-service/src/local/http/http_client.rs#L67
warning: useless conversion to the same type: `std::time::Instant` --> crates/shadowsocks-service/src/local/http/http_client.rs:67:25 | 67 | sleep.reset(new_deadline.into()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `new_deadline` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
build-unix (macos-latest, x86_64-apple-darwin)
gnu-tar 1.35 is already installed and up-to-date. To reinstall 1.35, run: brew reinstall gnu-tar
build-unix (macos-latest, aarch64-apple-darwin)
gnu-tar 1.35 is already installed and up-to-date. To reinstall 1.35, run: brew reinstall gnu-tar

Artifacts

Produced during runtime
Name Size
aarch64-apple-darwin Expired
7 MB
aarch64-unknown-linux-musl Expired
8.21 MB
windows-native Expired
21.1 MB
x86_64-apple-darwin Expired
9.68 MB
x86_64-unknown-linux-musl Expired
11.4 MB