Deal with warnings caused by outdated actions in workflows #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zedifen
commented
Jan 21, 2023
zedifen
changed the title
Replaces 'actions-rs/toolchain' with bare `rustup` command, since this action haven't been updated in 2 years and `rustup` is included in GitHub Action's runner images. See: https://github.com/actions/runner-images
Use 'kristof-mattei/clippy-check@main'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the workflow is using
actions/checkout@v2, which is outdated and generates warnings in workflow logs. This PR upgradeactions/checkoutto the latestv3.There are also two actions
actions-rs/toolchainandactions-rs/clippy-checkfrom actions-rs in use, which is also outdated and haven't been updated in years.This PR replaces
actions-rs/toolchainwith barerustupcommands, sincerustupis included in GitHub Actions runner images (see actions/runner-images).However there seems to be no easy way for replacing
actions-rs/clippy-check. So, I'm marking this a draft PR and open for further discussions.