Skip to content

feat(local): check integrity for online config #1131

feat(local): check integrity for online config

feat(local): check integrity for online config #1131

GitHub Actions / clippy ubuntu-latest succeeded May 13, 2024 in 0s

clippy ubuntu-latest

8 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 8
Note 0
Help 0

Versions

  • rustc 1.80.0-nightly (ef0027897 2024-05-12)
  • cargo 1.80.0-nightly (4de0094ac 2024-05-09)
  • clippy 0.1.80 (ef00278 2024-05-12)

Annotations

Check warning on line 1261 in src/service/local.rs

See this annotation in the file changed.

@github-actions github-actions / clippy ubuntu-latest

this operation has no effect

warning: this operation has no effect
    --> src/service/local.rs:1261:44
     |
1261 |             .unwrap_or(Duration::from_secs(1 * 60 * 60));
     |                                            ^^^^^^ help: consider reducing it to: `60`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
     = note: `#[warn(clippy::identity_op)]` on by default

Check warning on line 1231 in src/service/local.rs

See this annotation in the file changed.

@github-actions github-actions / clippy ubuntu-latest

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
    --> src/service/local.rs:1231:27
     |
1231 |             ConfigDisplay(&self),
     |                           ^^^^^ help: change this to: `self`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 1212 in src/service/local.rs

See this annotation in the file changed.

@github-actions github-actions / clippy ubuntu-latest

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
    --> src/service/local.rs:1212:37
     |
1212 |                         f.write_str(&online_config_url)?;
     |                                     ^^^^^^^^^^^^^^^^^^ help: change this to: `online_config_url`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 1191 in src/service/local.rs

See this annotation in the file changed.

@github-actions github-actions / clippy ubuntu-latest

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
    --> src/service/local.rs:1191:64
     |
1191 |             let mut online_servers = get_online_config_servers(&online_config_url).await?;
     |                                                                ^^^^^^^^^^^^^^^^^^ help: change this to: `online_config_url`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
     = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 201 in crates/shadowsocks-service/src/local/tun/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy ubuntu-latest

this comparison involving the minimum or maximum element for this type contains a case that is always true or always false

warning: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
   --> crates/shadowsocks-service/src/local/tun/mod.rs:201:24
    |
201 |                     if n <= IFF_PI_PREFIX_LEN {
    |                        ^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: because `IFF_PI_PREFIX_LEN` is the minimum value for this type, the case where the two sides are not equal never occurs, consider using `n == IFF_PI_PREFIX_LEN` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
    = note: requested on the command line with `-W clippy::absurd-extreme-comparisons`

Check warning on line 172 in crates/shadowsocks-service/src/local/tun/tcp.rs

See this annotation in the file changed.

@github-actions github-actions / clippy ubuntu-latest

transmute used without annotations

warning: transmute used without annotations
   --> crates/shadowsocks-service/src/local/tun/tcp.rs:172:38
    |
172 |         let recv_buf = unsafe { mem::transmute::<_, &mut [u8]>(buf.unfilled_mut()) };
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider adding missing annotations: `transmute::<&mut [std::mem::MaybeUninit<u8>], &mut [u8]>`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
    = note: `#[warn(clippy::missing_transmute_annotations)]` on by default

Check warning on line 197 in crates/shadowsocks-service/src/local/fake_dns/manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy ubuntu-latest

field assignment outside of initializer for an instance created with Default::default()

warning: field assignment outside of initializer for an instance created with Default::default()
   --> crates/shadowsocks-service/src/local/fake_dns/manager.rs:197:13
    |
197 |             c.ipv4_network = ipv4_network_str;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: consider initializing the variable with `local::fake_dns::proto::StorageMeta { ipv4_network: ipv4_network_str, ipv6_network: ipv6_network_str, version: FAKE_DNS_MANAGER_STORAGE_VERSION }` and removing relevant reassignments
   --> crates/shadowsocks-service/src/local/fake_dns/manager.rs:196:13
    |
196 |             let mut c = proto::StorageMeta::default();
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
    = note: `#[warn(clippy::field_reassign_with_default)]` on by default

Check warning on line 167 in crates/shadowsocks-service/src/local/fake_dns/manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy ubuntu-latest

this operation has no effect

warning: this operation has no effect
   --> crates/shadowsocks-service/src/local/fake_dns/manager.rs:167:34
    |
167 |             .flush_every_ms(Some(1 * 1000))
    |                                  ^^^^^^^^ help: consider reducing it to: `1000`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
    = note: `#[warn(clippy::identity_op)]` on by default