Skip to content

refactor: change error handling to be strongly-typed (#1834)

Sign in for the full log view
GitHub Actions / clippy macos-latest succeeded Jan 7, 2025 in 0s

clippy macos-latest

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a62 2024-11-26)

Annotations

Check warning on line 488 in src/service/server.rs

See this annotation in the file changed.

@github-actions github-actions / clippy macos-latest

useless use of `format!` 

warning: useless use of `format!`
   --> src/service/server.rs:484:61
    |
484 |               return Err(ShadowsocksError::InsufficientParams(format!(
    |  _____________________________________________________________^
485 | |                 "missing proxy servers, consider specifying it by \
486 | |                     --server-addr, --encrypt-method, --password command line option, \
487 | |                         or configuration file, check more details in https://shadowsocks.org/doc/configs.html"
488 | |             )));
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
help: consider using `.to_string()`
    |
484 ~             return Err(ShadowsocksError::InsufficientParams("missing proxy servers, consider specifying it by \
485 +                     --server-addr, --encrypt-method, --password command line option, \
486 ~                         or configuration file, check more details in https://shadowsocks.org/doc/configs.html".to_string()));
    |

Check warning on line 463 in src/service/manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy macos-latest

useless use of `format!` 

warning: useless use of `format!`
   --> src/service/manager.rs:460:50
    |
460 |               ShadowsocksError::InsufficientParams(format!(
    |  __________________________________________________^
461 | |                 "missing `manager_address`, consider specifying it by --manager-address command line option, \
462 | |                     or \"manager_address\" and \"manager_port\" keys in configuration file"
463 | |             ))
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
help: consider using `.to_string()`
    |
460 ~             ShadowsocksError::InsufficientParams("missing `manager_address`, consider specifying it by --manager-address command line option, \
461 ~                     or \"manager_address\" and \"manager_port\" keys in configuration file".to_string())
    |

Check warning on line 945 in src/service/local.rs

See this annotation in the file changed.

@github-actions github-actions / clippy macos-latest

useless use of `format!` 

warning: useless use of `format!`
   --> src/service/local.rs:942:61
    |
942 |               return Err(ShadowsocksError::InsufficientParams(format!(
    |  _____________________________________________________________^
943 | |                 "missing `local_address`, consider specifying it by --local-addr command line option, \
944 | |                     or \"local_address\" and \"local_port\" in configuration file"
945 | |             )));
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
    = note: `#[warn(clippy::useless_format)]` on by default
help: consider using `.to_string()`
    |
942 ~             return Err(ShadowsocksError::InsufficientParams("missing `local_address`, consider specifying it by --local-addr command line option, \
943 ~                     or \"local_address\" and \"local_port\" in configuration file".to_string()));
    |
View more details on GitHub Actions