test: Cache Babel output #5539
Merged
test: Cache Babel output #5539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: No instrumented code was changed. |
This should speed up local test runs, but also Selenium lab runs. Babel output and node_modules will both be computed by the singular build-shaka job and then reused by all the Selenium lab matrix jobs.
joeyparrish
force-pushed
the
babel-caching
branch
from
318803a
to
1f3c28f
Compare
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
theodab
approved these changes
Aug 28, 2023
avelad
approved these changes
Aug 28, 2023
avelad
added
the
component: tests
joeyparrish
added a commit
that referenced
this pull request
Aug 30, 2023
This caches Babel's transpiler output for reuse, and should speed up all test runs in theory, but the effect is most noticeable on local test runs. This uses a fork of karma-babel-preprocessor, which contains babel/karma-babel-preprocessor#77. If/when that PR is merged, we can move back to the upstream module. Local runs will start faster because only modified source files will be re-processed through Babel when the tests start up. In the Selenium workflow, Babel output and node_modules will both be computed by the singular build-shaka job, stored, and then reused by all the Selenium lab matrix jobs. On my workstation (3.3 GHz cores, 32GB RAM, spinning platter disk), I see tests start about ~60 seconds faster. In the lab (2.1-4.7 GHz cores, 64GB RAM, solid-state disk), I see tests start about ~10 seconds faster.
joeyparrish
added a commit
that referenced
this pull request
Aug 30, 2023
This caches Babel's transpiler output for reuse, and should speed up all test runs in theory, but the effect is most noticeable on local test runs. This uses a fork of karma-babel-preprocessor, which contains babel/karma-babel-preprocessor#77. If/when that PR is merged, we can move back to the upstream module. Local runs will start faster because only modified source files will be re-processed through Babel when the tests start up. In the Selenium workflow, Babel output and node_modules will both be computed by the singular build-shaka job, stored, and then reused by all the Selenium lab matrix jobs. On my workstation (3.3 GHz cores, 32GB RAM, spinning platter disk), I see tests start about ~60 seconds faster. In the lab (2.1-4.7 GHz cores, 64GB RAM, solid-state disk), I see tests start about ~10 seconds faster.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caches Babel's transpiler output for reuse, and should speed up all test runs in theory, but the effect is most noticeable on local test runs.
This uses a fork of karma-babel-preprocessor, which contains babel/karma-babel-preprocessor#77. If/when that PR is merged, we can move back to the upstream module.
Local runs will start faster because only modified source files will be re-processed through Babel when the tests start up.
In the Selenium workflow, Babel output and node_modules will both be computed by the singular build-shaka job, stored, and then reused by all the Selenium lab matrix jobs.
On my workstation (3.3 GHz cores, 32GB RAM, spinning platter disk), I see tests start about ~60 seconds faster. In the lab (2.1-4.7 GHz cores, 64GB RAM, solid-state disk), I see tests start about ~10 seconds faster.