Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder deletion not catched #86 #130

Open
wants to merge 156 commits into
base: master
Choose a base branch
from
Open

Folder deletion not catched #86 #130

wants to merge 156 commits into from

Conversation

floz
Copy link

@floz floz commented Jul 1, 2014

Solving this issue: #86
Tell me what you think about it!

Thanks

shama added 30 commits March 19, 2014 21:14
These tests were for specific cases handled by private methods
that have now been removed and therefore these tests should be removed.
@floz
Copy link
Author

floz commented Jul 1, 2014

However those 2 lines (148&149):
Gaze.super_.prototype.emit.apply(self, args);
Gaze.super_.prototype.emit.apply(self, ['all', e].concat([].slice.call(args, 1)));
Cause the this.on( "deleted" ) to fire twice. Is that a normal behavior?

@avanderhoorn
Copy link

I'm running into this issue too. +1 for fixing it.

Any news on when it will come in?

@shama
Copy link
Owner

shama commented Jul 6, 2014

Thanks for the PR @floz but I'm going to handle this a bit differently. I want to make it an option with deleted as the default, make sure it is cross platform and add tests into the test suite for it.

Re: those 2 lines. The first line emits for the specific event, i.e. deleted, added, changed, etc and the second emits for the all event.

@avanderhoorn
Copy link

Thanks for the update!

@floz
Copy link
Author

floz commented Jul 6, 2014

Hey Shama,
Cool, thanks for the answer & the explanations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants