-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch FOXy from web3 to ethers and JsonRpcBatchProvider #3508
Merged
gomesalexandre
merged 29 commits into
develop
from
feat_accomodate_new_investor_foxy_types
Apr 25, 2023
Merged
feat: switch FOXy from web3 to ethers and JsonRpcBatchProvider #3508
gomesalexandre
merged 29 commits into
develop
from
feat_accomodate_new_investor_foxy_types
Apr 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
9951649
to
660bba8
Compare
6e55bec
to
7c55569
Compare
src/features/defi/providers/foxy/components/FoxyManager/Overview/Claim/ClaimStatus.tsx
Show resolved
Hide resolved
src/features/defi/providers/foxy/components/FoxyManager/Deposit/components/Confirm.tsx
Show resolved
Hide resolved
src/features/defi/providers/foxy/components/FoxyManager/Withdraw/components/Confirm.tsx
Show resolved
Hide resolved
src/features/defi/providers/foxy/components/FoxyManager/Withdraw/components/Confirm.tsx
Outdated
Show resolved
Hide resolved
src/features/defi/providers/foxy/components/FoxyManager/Deposit/components/Confirm.tsx
Outdated
Show resolved
Hide resolved
bd0187b
to
ed53a49
Compare
kaladinlight
previously approved these changes
Apr 25, 2023
…ous gasLimit/gasPrice from ethers
instead, removing a bunch more useless duplicate logic while at it
da89ac8
to
61a91a6
Compare
kaladinlight
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getXYZGas
->getXYZFees/Estimate
vernacular in diffed methodsshouldUseEip1559Fees
This PR:
JsonRpcBatchProvider
so that FOXy Ethereum JSON-RPC calls are batchedETHWallet
/EVMBaseAdapter
investor-foxy
:gasPrice
andgasLimit
estimations to unchained estimations, which should be more accuratefees
vernacular vsgas
vernacular in fees estimation methods, which now return aFeeDataEstimate
buildTxToSign
and use chain-adaptersbuildCustomTx
insteadgetGasPriceAndNonce
, which isn't needed anymore now that we usechain-adapters
so nonce will be correctly gotten there, and gas price is now useless because we use fees estimationWhile at it, replaces all instances of
JsonRpcProvider
in web/packages to beJsonRpcBatchProvider
, which will provide implicit batching whenever possible.Notice
Pull Request Type
Issue (if applicable)
N/A
Risk
FOXy might be borked - tested deposit approval and deposit Txs through MM, and ran both instant and delayed withdraw ones through Tenderly, which were happy. Was unable to test claims
Testing
Engineering
getRebaseHistory
:Operations
Screenshots (if applicable)