Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix override of --plain and --paging #3108

Merged

Conversation

einfachIrgendwer0815
Copy link
Contributor

@einfachIrgendwer0815 einfachIrgendwer0815 commented Oct 18, 2024

Fixes #2731 while maintaining what #2660 tried to achieve.

That means the following combinations of --plain and --paging now work as expected:

bat <file> --plain --paging=never           # plain style, no paging
bat <file> --plain --plain --paging=always  # plain style, paging -> the second --plain gets overriden by --paging=always but not the first
bat <file> --paging=never --plain           # plain style, no paging

Fixes #2731
Fixes #3035

@keith-hall keith-hall merged commit ce7a3d9 into sharkdp:master Oct 31, 2024
24 checks passed
@keith-hall
Copy link
Collaborator

Thanks! :)

@einfachIrgendwer0815 einfachIrgendwer0815 deleted the fix/2731_plain_override branch October 31, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bat --paging=never --plain] still paging, since version 0.24.0 --pager=never does not respect --plain
2 participants