Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only colors supported by conhost.exe #661

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gordon01
Copy link

@Gordon01 Gordon01 commented Jun 23, 2023

The previous terminal for Windows is conhost.exe (the one with blue background) which renders some colors differently.
Green and Red, for example, are quite dim, whereas, on typical unix terminal and modern Windows Terminal, they're indistinguishable from "normal" ones.

This patch changes the overall hyperfine color scheme to a few "safe" colors in the following manner.

Color scheme

Main measurement text:

green -> yellow bold
green bold -> yellow bold

Min:

cyan -> bright green

Max:

purple -> bright red

Other:

blue -> cyan
magenta -> cyan

Before:

conhost.exe

image
image

Windows Terminal

image

VS Code

image

After:

conhost.exe

image
image

Windows Terminal

image

VS Code

image

This PR addresses #507

@Gordon01
Copy link
Author

Sorry forgot to change min label color. Now it's correct:

image

@sharkdp
Copy link
Owner

sharkdp commented Oct 5, 2023

Thank you. Maybe it's just me, but I liked the previous colors better. Is there any way we can do a minimal fix without changing everything? Possibly only on Windows, or ideally only on "affected" terminal emulators?

@Gordon01
Copy link
Author

Gordon01 commented Oct 9, 2023

I guess it's pretty hard to reason about what colors "are better". I'm definitely not ready for it...

Possibly only on Windows, or ideally only on "affected" terminal emulators?

It's doable, I can try if you're fine with additional code

@sharkdp
Copy link
Owner

sharkdp commented Jun 23, 2024

I would favor a solution where we put all of the used colors in one central place. And then we could have two variants of the "theme", one for cases where we assume that we are running in a old-style blue Windows terminal, and the default theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants