Use only colors supported by conhost.exe #661
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous terminal for Windows is
conhost.exe
(the one with blue background) which renders some colors differently.Green and Red, for example, are quite dim, whereas, on typical unix terminal and modern Windows Terminal, they're indistinguishable from "normal" ones.
This patch changes the overall
hyperfine
color scheme to a few "safe" colors in the following manner.Color scheme
Main measurement text:
Min:
Max:
Other:
Before:
conhost.exe
Windows Terminal
VS Code
After:
conhost.exe
Windows Terminal
VS Code
This PR addresses #507