Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode extension packaging #656

Merged

Conversation

Goju-Ryu
Copy link
Contributor

@Goju-Ryu Goju-Ryu commented Nov 14, 2024

This PR sets up the vs-code extension to make it easy to package.

I also added and changed a few things:

  • Replaced template text in README with text relevant the numbat extension
  • Added extension Icon
  • Used numbat icon for numbat files
  • Added license, repo, and homepage information
  • Added keywords
  • Redesigned how string highlighting is passed (this fixes some highlighting bugs and adds support for multi line strings)

What it looks like:
image
image

@Goju-Ryu
Copy link
Contributor Author

Installing it is very easy and can be summed up in a single picture:
image
Click Install from VSIX... select the VSIX file in the file selector that pops up and it is automatically installed.

That said, it is currently not easy to get the VSIX file without getting the repo and creating it for yourself. I am not sure what the best way to solve it is, but an easy solution is to release it with the other numbat assets in each release. I will update the README and Numbat documentation to reflect how we distribute the VSIX when we have decided.

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you very much.

vscode-extension/README.md Outdated Show resolved Hide resolved
@sharkdp sharkdp merged commit 86c80e5 into sharkdp:master Nov 21, 2024
4 checks passed
@sharkdp
Copy link
Owner

sharkdp commented Nov 21, 2024

an easy solution is to release it with the other numbat assets in each release.

👍

I will update the README and Numbat documentation to reflect how we distribute the VSIX when we have decided.

That would be fantastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants