Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🗣️ Multi languages support #360

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

philippart-s
Copy link
Contributor

@philippart-s philippart-s commented Feb 13, 2023

A proposition to add the ability to have the resume in several languages without to duplicate the all code.

It's improvable but it's a first version 😉.

An example of the generated CV:

image

@nelsonmestevao
Copy link
Collaborator

nelsonmestevao commented Jul 28, 2023

@philippart-s can you fix conflicts, please?

@philippart-s
Copy link
Contributor Author

@nelsonmestevao done 😉

@nelsonmestevao
Copy link
Collaborator

@sharu725 feel free to merge it if you agree 💪

@nelsonmestevao
Copy link
Collaborator

@philippart-s can you rebase to adder to more recent update of the folder structure?

@sharu725
Copy link
Owner

This is nice @philippart-s but it isn't the standard used across the web.
I think the link https://online-cv.webjeda.com/fr should be used for French.

Renaming index-fr to fr will do that.

But I still think there should be an easier way for the end-users to configure another language. At the moment, they'll have to edit a bunch of pages like the layout page, print page, and the language page itself.

Something like this would be good - https://github.com/kurtsson/jekyll-multiple-languages-plugin

@philippart-s
Copy link
Contributor Author

yes you're right, I've not tested the Jekyll plugin you mention.
I'll take a look 😉.

Fell free to close this PR if you think it's not a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants