GUI: Rework the Tab side menus #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure we update the tree side menu when an analysis has been run.
Otherwise we were ending up with a mix of colours from different colouring systems. This was missed when storing colours in commit d60f19d
And remove it from the display menu.
These were missed in recent commits that focused on the spatial tab.
Micro-optimisation but might be useful.
Useful for large data sets.
This makes it available to other tab objects.
And in the process, we now keep track of the plot mode across trees. So if a user wants depth based plotting then this is consistent as the tree is changed.
Has a lot of overlap with the Labels tab, but there are sufficient differences to suggest refactoring would make maintenance harder.
And clean up the old stuff.
Avoids some double firing of events.
Also avoid some uninitialised warnings.
This unifies the interfaces across the different tab types and enables a future refactor to combine the common tree menu items.
Same process as the previous commit, although it is only used in the Clustering tab and its subclasses.
These were repeated across several packages.
Otherwise we lose all keyboard shortcuts.
Might have some gremlins lurking but they will manifest through usage.
This makes more sense now we have separated the tree options into a separate menu. Add some separators as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something of an omnibus PR as it addresses several issues encountered while working on #902.
Updates #902 - support exports of the displayed tree
Updates #905 - tree plot controls are now in their own submenu of the side menu
Updates #906 - support tree plotting by depth across all tabs that plot trees
Fixes #908 - export interface disables keyboard shortcuts
Also refactors (nearly) all of the
$self->{xmlPage}->get_objectcalls to use a generic method.