Prevent API crash by sanitizing user input strings #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Character and player names are end-user controlled, and can contain invalid characters that will cause the API to crash.
|
Sorry, I just noticed this. I'll take a look and see about integrating your suggestions. I actually do all my development in a different repo, so merging directly here isn't part of my process, but I appreciate you taking the time to send this issue to me, complete with a possible solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user includes invalid Roll20 API markup in their player or character name, the TurnMarker crashes. By sanitizing the names, we prevent ignorant or malicious players from crashing the API.