Bounty v2 #786
Merged
Bounty v2 #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f171029.
* add go-ethereum ecies generatekey * resume buf compilation * goimports bounty file * change encryption_key type to any * add TestSaveLoadKey * sort import * sort msg import
* Add bounty module account 1. Add test case. 2. Add bounty account. 3. set default value. * Add test case * Add test case
* add finding init * add programid:findinglist * add go-ethereum ecies generatekey * resume buf compilation * goimports bounty file * change encryption_key type to any * change encrypted_desc type to any * change severity level type to enum * add TestSaveLoadKey * sort import * severityLevel as enum * add findings to genesisState * merged bounty-encryption * add finding status * init SetNextFindingID * fix golint * pid to program_id, fid to finding_id * pid to program_id, fid to finding_id * fix some format error * add FlagSubmissionEndTime flag * improve TestFinding and TestProgram * improve encrypteddesc, encryptedpoc,encryptionkey test
* Bounty query * Add test case * Add test case * Fix test case error * Fix conflict * Add test case * Add finding query * fix golangci-lint error * Add test case
* add a helper.go * fix golangci-lint error
* Add host accept or reject finding * fix test error
* add plain text of desc and poc in proto file * add comment to finding * add release finding process * reset to release finding one by one, and merge encrypted_desc,desc to one accept interface * fix lint * fix finding comment
* check deposit in validateBasic * check deposit in MsgCreateProgram validateBasic
* finding withdrawal * fix lint * change name & wrap errors & event field * fix ut * update merge conflict * update merge conflict
haozhan9
reviewed
Nov 16, 2023
haozhan9
reviewed
Nov 16, 2023
x/bounty/client/rest/query.go
Outdated
| // Get all delegations from a delegator | ||
| r.HandleFunc( | ||
| "/bounty/programs/{programID}", | ||
| programsHandlerFn(clientCtx), |
There was a problem hiding this comment.
seems we didn't actually implement this. still need this code?
haozhan9
reviewed
Nov 17, 2023
| return &types.QueryProgramResponse{Program: program}, nil | ||
| } | ||
|
|
||
| func (k Keeper) Findings(c context.Context, req *types.QueryFindingsRequest) (*types.QueryFindingsResponse, error) { |
There was a problem hiding this comment.
please correct me if I'm wrong.
This query is supposed to return all finding for a program? or just return all stored findings?
It seems the finding returned would be empty.
haozhan9
approved these changes
Nov 17, 2023
kevin-yuhh
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Related: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)