Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update upgrade handler for v2.9.0 #793

Merged
merged 3 commits into from
Nov 17, 2023
Merged

update upgrade handler for v2.9.0 #793

merged 3 commits into from
Nov 17, 2023

Conversation

skyargos
Copy link
Contributor

Closes: #XXX
Related: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]"

@skyargos skyargos requested a review from a team as a code owner November 16, 2023 04:43
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #793 (8227bcb) into master (9a881da) will increase coverage by 1.10%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   46.42%   47.53%   +1.10%     
==========================================
  Files         142      142              
  Lines       13608    13292     -316     
==========================================
  Hits         6318     6318              
+ Misses       6732     6416     -316     
  Partials      558      558              
Files Coverage Δ
app/upgrade_handler.go 17.39% <0.00%> (+16.21%) ⬆️

Copy link
Contributor

@0311xuyang 0311xuyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyargos skyargos merged commit 05b7947 into master Nov 17, 2023
19 of 20 checks passed
@skyargos skyargos deleted the v290-upgrade_handler branch November 17, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants