Update editors #14
Open
Update editors #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add equation numbers to some additional equations that seem important. Add IDs to the different filter equations so we can link to them easily.
Fix the typos: * Coefficients should be subscripted for BPF (constant skirt gain) * Remove asterisk in Eq 19 that was used originally for multiplication * Make outer parens bigger to show levels better Also modified 'A*Q` to be `\[A\cdot Q\]`
Fix #8: fix typos in formulas
Forgot to fix up the coefficient names for this filter.
Quite a few places didn't use inline math for things like S and Q and f0/Fs. Make these inline math, as expected. These issues were found by Robert Bristow-Johnson.
* Allow MathJax to look in code and pre tags for math. * Change the package to tex-chtml.js; we don't really need mml output.
First, we incorrectly set the MathJax option to allow math in pre blocks, so fix that. Then replace <displayed-eqn> tags with <pre>. Finally, run tidy.
Indent equations nicely to make them easier to read. Also update .tidyrc because we don't need to tell tidy about displayed-eqn anymore.
The MathJax docs recommend setting the viewport meta tag because MathJax can be confused without it resulting in very small font sizes. Might help out on mobile devices too.
Well, looks mostly the same everywhere. Rather arbitrarily chose Lora because it kind of matches MathJax reasonably well. (But others would work too, like Merriweather or EB Garamond or Vollkorn.)
The formulas for the bilinear transformation and the derivation get numbers to make it easy to reference.
When two fractions are multiplied together, it's hard to see that there's a gap, so it looks like just one fraction smashed together in a funny way. Increasing the spacing helps a little, but let's make it more obvious by using \times to indicate that the fractions are multiplied together.
For each filter type, there is a group of 6 equations giving the coefficients of the filter. Add an equation number of the group. Didn't want to add one for each equation because that would be too many. And MathJax doesn't support the subequations environment so we can't easily add a subequation (1a,1b, ect).
Add these ids so we can link to the filter coefficients from other HTML documents.
The displayed equation for sin^2 doesn't really need to be displayed. Making it inline doesn't harm readability so make it inline.
Robert Bristow-Johnson suggested adding me as an editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Robert Bristow-Johnson suggested adding me as an editor.