-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding DigitalSpy #2312
base: master
Are you sure you want to change the base?
Adding DigitalSpy #2312
Conversation
@ppfeister this is my first time contributing, please tell me if the code needs changes |
"errorType": "message", | ||
"url": "https://forums.digitalspy.com/profile/{}", | ||
"urlMain": "https://forums.digitalspy.com/", | ||
"username_claimed": "papita69" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good add! The only issue is that this username no longer appears to be active. When testing with blue
however, it works as expected.
Probably worked fine when you added it, the account just closed down.
"username_claimed": "papita69" | |
"username_claimed": "blue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted,
"errorMsg": "The page you were looking for could not be found.", | ||
"errorType": "message", | ||
"url": "https://forums.digitalspy.com/profile/{}", | ||
"urlMain": "https://forums.digitalspy.com/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that DigitalSpy's username requirements are public:
Username can only contain letters, numbers, underscores, and must be between 3 and 20 characters long.
Could you add a regexCheck to match this? Not sure if you've dealt with regex before. I can provide a pattern for you if need be.
Note that this isn't a PROBLEM, just an improvement. It helps reduce traffic against any one target, which in turn reduces the odds of you getting rate limited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would very much like to add a regexCheck if you'd provide me with how to proceed with it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough for this one, actually. The word character class \w
just so happens to expand to exactly those characters [a-zA-Z0-9_]
(letters, numbers, underscores). Pattern here for 3-20 chars would just be ^\w{3,20}$
Would need to escape the backslash in this case due to Python stuff: ^\\w{3,20}$
. ^
for start of string and $
for end of string.
So "regexCheck": "^\\w{3,20}$"
should be it, really.
Prefilled regex101 link if curious about the pattern: https://regex101.com/r/4fLLj0/1 (great tool for writing and testing patterns)
added support for the Digital Spy Forum. Digital Spy is a UK-based entertainment and media news website, known for covering television, movies, and celebrity news, as well as offering discussion forums for users.