Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the new components after refactor #205

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sidtohan
Copy link
Contributor

Description

This PR contains the new components created during the refactor process, these are NOT used in any of the older components yet, that would be included in a separate PR.

Changes

  1. Ditched the atoms and molecules terminology and now simply use simple and composite components, and made folders for the same.
  2. Created the storybook config file(currently not working due to some dependency issue, may be sorted out later).
  3. Added utils folder containing some utility functions and typeguards, as well as custom hooks that helped in reducing size of the main components.
  4. Added calls folder inside services which aims to separate API calls into one location for easier debugging.

P.S:
Currently working in a different environment so please don't mind the commits from a different account, this is just temporary.

@sidtohan sidtohan force-pushed the sidtohan/newcomp/attendance branch from 87ed602 to 32e16e3 Compare July 13, 2022 12:00
@sidtohan
Copy link
Contributor Author

@Shruti3004 ma'am could you please have a look on why is this failing? Seems to be some kind of issue in react native base, but I don't have an idea on how to fix it.

@Shruti3004
Copy link
Member

Hey @sidtohan will look at it.

@sidtohan sidtohan force-pushed the sidtohan/newcomp/attendance branch from cfbf34c to f1ebd36 Compare July 13, 2022 18:50
@sidtohan
Copy link
Contributor Author

@Shruti3004 @coolbung Now the build is running, please kindly have a look whenever possible.

@sidtohan sidtohan force-pushed the sidtohan/newcomp/attendance branch from f1ebd36 to 5341a9c Compare July 14, 2022 11:39
@sidtohan sidtohan force-pushed the sidtohan/newcomp/attendance branch 4 times, most recently from d596e92 to a827905 Compare July 24, 2022 15:03
sidtohan added 2 commits July 27, 2022 00:34
…equired config files

* recommended to revert to LTS node version for consistent performance and dealing with issues related to ip
* make sure to use the wrapper to ensure that the storybook is able to find the context for react native web components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants