Added utility folder to common-lib #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidtohan
force-pushed
the
sidtohan/utils/commonlib
branch
from
e0ce05f to
02ff2b3
Compare
|
Please put a comment in each of these hooks / functions to explain the purpose of each. |
Shruti3004
approved these changes
Jul 19, 2022
* Many utilities are shared across modules, having them all in common lib may help * For now only the utils folder has been added there, config must be modified to produce appropriate typings
* Added comments to all functions, custom hooks and types to briefly describe their use * Removed some redundant utilities that were not needed when the code is in utils folder
sidtohan
force-pushed
the
sidtohan/utils/commonlib
branch
from
74e78e6 to
dd98c8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think it would be wise decision to include the utils folder in the common lib module since there are many utilities which are shared among modules. For example,
both the attendance and calendar module use the formatDate function.
There may be many more such repeated functions in the code so I think having them all in common lib increases re usability.
Changes
The directory structure is now as follows:
Note:
Currently the typings for utils is not being produced by common lib. I think it may be a config issue so any help there may be appreciated.