Refactored the QuestionBox Component in Worksheet #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidtohan
force-pushed
the
sidtohan/tsrefactor/questionbox
branch
2 times, most recently
from
08accaf to
ab26f0d
Compare
* added interfaces wherever applicable * created a new component HTMLPrint, that renders the given HTML in a div and returns it, shifted it from outside index.tsx to make it easier to use in other components(if required) * extracted one component 'QuestionOption' from QuestionBox to increase readibility
sidtohan
force-pushed
the
sidtohan/tsrefactor/questionbox
branch
from
ab26f0d to
bfa9a20
Compare
|
@Shruti3004 @coolbung @sagarkoshti1990 please kindly review whenever possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the QuestionBox component in the module Worksheet as part of the refactoring progress
Changes
How to test
lerna run start --parallel --scope='{worksheet,@shiksha/common-lib,core,students,attendance}'Refactored Components
QuestionOption
HTMLPrint