ISSUE #ED-431 feat : Added Program details page #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISSUE #ED-431 feat : Added Program details page
Fetching details from api done in program details page
Added PII consent popup
ISSUE #ED-431 feat : UI changes done for program details page
ISSUE #ED-1560 feat : Files saves for Project evidences
Added toast message for project details page
| @@ -9,6 +9,8 @@ import { RouterLinks } from '@app/app/app.constant'; | |||
| import { TranslateModule } from '@ngx-translate/core'; | |||
| import { FormsModule } from '@angular/forms'; | |||
| import { CoreModule } from '../core/core.module'; | |||
| import { ProgramDetailsComponent } from './program-details/program-details.component'; | |||
| import { CommonConsumptionModule } from '@project-sunbird/common-consumption'; | |||
There was a problem hiding this comment.
why this is required? and what purpose you imported here
There was a problem hiding this comment.
As we are using sb-library-filters in program-details page, we need to import the CommonConsumptionModule
| }) | ||
| export class PiiConsentPopupComponent implements OnInit { | ||
|
|
||
| @Input() msg1 |
There was a problem hiding this comment.
give proper and generic names
| } | ||
|
|
||
|
|
||
| converDataSrcToObject(ele) { |
There was a problem hiding this comment.
spelling correction
Naming changes in consent popup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Program details page when users have joined and not joined the program