Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec-sync is deprecated. use execSync or native (node 0.11+) #1

Merged
merged 2 commits into from
Jan 12, 2015
Merged

exec-sync is deprecated. use execSync or native (node 0.11+) #1

merged 2 commits into from
Jan 12, 2015

Conversation

matt-cook
Copy link
Contributor

based on readme for exec-sync: https://github.com/jeremyfa/node-exec-sync

and comment here: mgutz/execSync#20 (comment)

shime added a commit that referenced this pull request Jan 12, 2015
@shime
Merge pull request #1 from zebradog/master
fdbb440 
exec-sync is deprecated. use execSync or native (node 0.11+)
@shime shime merged commit fdbb440 into shime:master Jan 12, 2015
@shime
Copy link
Owner

shime commented Jan 12, 2015

Thanks!

shime added a commit that referenced this pull request Jan 12, 2015
@shime
Revert "Merge pull request #1 from zebradog/master"
87f66bf 
This reverts commit fdbb440, reversing
changes made to 9d28c3c.
@shime
Copy link
Owner

shime commented Jan 12, 2015

Actually, I reverted it since exec-sync is still in better condition than execSync - the latter doesn't have the same API as child_process.execSync (doesn't throw on non-zero exit status).

@shime
Copy link
Owner

shime commented Jan 12, 2015

Meh, replaced exec-sync with execSync and ditched support for child_process for now. Let's see if that helps OSX...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-cook @shime