Skip to content

Commit

Permalink
Fixes Centcom Ban DB erroring out with bad index (#3337)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

BYOND 515 "fixes" an undocumented feature where vars can be accessed on
objects by accessing them like a list. I fix this on Yogstation too so I
might as well port it here cause you guys are nice (hi shiptest!)
yogstation13/Yogstation#22586

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

We should be able to use this if we have it!

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: Centcom Ban DB is now accessible again through PP
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
ToasterBiome authored Sep 13, 2024
1 parent e02e490 commit 0aa2035
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion code/modules/admin/topic.dm
Original file line number Diff line number Diff line change
Expand Up @@ -1973,7 +1973,7 @@
if(response.body == "[]")
dat += "<center><b>0 bans detected for [ckey]</b></center>"
else
bans = json_decode(response["body"])
bans = json_decode(response.body)

//Ignore bans from non-whitelisted sources, if a whitelist exists
var/list/valid_sources
Expand Down

0 comments on commit 0aa2035

Please sign in to comment.