Skip to content

Commit

Permalink
Glasses Transparency Tweaks (#2711)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
Resurrects #2595 from
stale hell, with the requested adjustments.

From the original PR: Changes the sprites of the prescription glasses,
and prescription HUD glasses, to be more transparent with less varying
colors. Also a semi port of
yogstation13/Yogstation#19641

Additionally, brings over the thin prescription glasses from
tgstation/tgstation#62145

![take a closer look at those
peepers](https://github.com/shiptest-ss13/Shiptest/assets/86762641/20f3b4dc-d00c-4dca-8b60-fe3ac1cd20fc)
## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->
I don't know about you, but I'd like to not have my character's eyes
locked behind the eternal damnation that is mandatory opaque glasses. As
the original author pointed out, it'll also help to make sunglasses huds
and prescription huds a bit more visually distinct from one another.

## Changelog

:cl:
add: new pair of prescription glasses, now available in loadouts!
imageadd: new transparent sprites for all prescription glasses
imageadd: new transparent sprites for all prescription HUDs
imageadd: new transparent sprite for the orange sunglasses
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
Skies-Of-Blue authored Feb 9, 2024
1 parent 9250185 commit 167e5a2
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 3 deletions.
12 changes: 9 additions & 3 deletions code/modules/client/loadout/loadout_eyewear.dm
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
display_name = "glasses, prescription"
path = /obj/item/clothing/glasses/regular

/datum/gear/eyewear/glasses/thin
display_name ="glasses, thin prescription"
path = /obj/item/clothing/glasses/regular/thin

/datum/gear/eyewear/glasses/large
display_name = "glasses, large prescription"
path = /obj/item/clothing/glasses/regular/circle
Expand All @@ -16,6 +20,10 @@
display_name = "glasses, jamjar prescription"
path = /obj/item/clothing/glasses/regular/jamjar

/datum/gear/eyewear/hipster_glasses
display_name = "glasses, hipster prescription"
path = /obj/item/clothing/glasses/regular/hipster

//Misc
/datum/gear/eyewear/eyepatch
display_name = "eyepatch"
Expand All @@ -38,9 +46,7 @@
description = "A blindfold you can still see through."
path = /obj/item/clothing/glasses/trickblindfold

/datum/gear/eyewear/hipster_glasses
display_name = "Hipster Glasses"
path = /obj/item/clothing/glasses/regular/hipster


/datum/gear/eyewear/glasses/cold
display_name = "cold goggles"
Expand Down
5 changes: 5 additions & 0 deletions code/modules/clothing/glasses/_glasses.dm
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@
icon_state = "circle_glasses"
item_state = "circle_glasses"

/obj/item/clothing/glasses/regular/thin
name = "thin glasses"
desc = "More expensive, more fragile and much less practical, but oh so fashionable."
icon_state = "thin_glasses"

//Here lies green glasses, so ugly they died. RIP

/obj/item/clothing/glasses/sunglasses
Expand Down
Binary file modified icons/mob/clothing/eyes.dmi
Binary file not shown.
Binary file modified icons/obj/clothing/glasses.dmi
Binary file not shown.

0 comments on commit 167e5a2

Please sign in to comment.