Skip to content

Commit

Permalink
(probably) actually fixes outpost baseturfs, removes holodecks (#2598)
Browse files Browse the repository at this point in the history
## About The Pull Request

changes the behavior downstream of /datum/map_template's
should_place_on_top (the particular proc in question is
build_coordinate, and its placeOnTop variable) so that, when false, the
baseturfs of the resulting turf are set to the baseturfs of the type
being placed, instead of the previous behavior, which preserved the old
baseturfs entirely.

this odd behavior seemed to be specialized for holodecks, and i
mistakenly assumed it'd work for outposts given the variable name and an
experiment on a testing map. the behavior has been changed to alter the
baseturfs according to the type (so that placing a template with
should_place_on_top = FALSE results in the same baseturfs list as you'd
get from a changeturf(type, initial(type.baseturfs) call), so that
outposts should now place with the correct baseturfs. this enables
planetary outposts with a special baseturf defined in a ztrait; before,
they would be stuck with a space turf hiding in the baseturf list,
making their baseturfs basically always broken.

in order to accommodate this change without breaking holodeck code,
holodeck code has been largely removed, with a few exceptions where it'd
be a slight pain to remove certain turfs / objects that were originally
used in holodecks but which had been since used in other maps. there's
also a bit of admin functionality upstream of some holodeck procs that i
didn't want to touch

## Why It's Good For The Game

outposts spacing themselves when people pry up tiles is bad, and a fix
like this is necessary for planetary outposts to ever have the right
baseturfs.

## Changelog

:cl:
del: Holodeck code has been removed.
fix: Outposts should end up erroneously spaced less frequently.
/:cl:
  • Loading branch information
tmtmtl30 authored Jan 14, 2024
1 parent 3376971 commit 226734e
Show file tree
Hide file tree
Showing 42 changed files with 35 additions and 6,918 deletions.
2 changes: 1 addition & 1 deletion _maps/RandomRuins/SpaceRuins/corporate_mining.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@
/area/ruin/space)
"ov" = (
/obj/structure/table/wood/poker,
/obj/effect/holodeck_effect/cards,
/obj/item/toy/cards/deck,
/obj/machinery/atmospherics/pipe/simple/supply/hidden/layer2{
dir = 10
},
Expand Down
177 changes: 0 additions & 177 deletions _maps/templates/holodeck_animeschool.dmm

This file was deleted.

130 changes: 0 additions & 130 deletions _maps/templates/holodeck_anthophillia.dmm

This file was deleted.

Loading

0 comments on commit 226734e

Please sign in to comment.