Skip to content

Commit

Permalink
Roundstart Audio Replacement & Roundend Audio DLC #1 (#2837)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
**SOUL REMOVAL**

Replaces the stock /tg/ welcome message with something a little more
relevant, and replaces all of our roundend audio clips with a few
shiptesting cultural touchstones.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Out of all of the things we've inherited from /tg/station, the
roundstart/end audio clips were always fairly low on the list of things
that needed replacing. After hearing _Welcome to the station crew, enjoy
your stay_ and _Now departing /tg/station_ several hundred times over,
however, I finally think the soul has overstayed its welcome.

This helps us distinguish ourselves from other /tg/ downstreams in a
subtle but impactful way, hopefully giving new players a "We're not in
Kansas anymore" feeling and allowing veterans to point their finger at
the screen and go "I understood that reference!"
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
soundadd: several new roundend audio clips, as well as a new roundstart
clip
sounddel: all of the old roundend audio clips, as well as the old
roundstart clip
del: soul
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
Skies-Of-Blue authored Mar 15, 2024
1 parent 046245f commit 285b6bd
Show file tree
Hide file tree
Showing 17 changed files with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions code/controllers/subsystem/ticker.dm
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ SUBSYSTEM_DEF(ticker)

to_chat(world, "<span class='notice'><B>Welcome to [station_name()], enjoy your stay!</B></span>")
SSredbot.send_discord_message("ooc", "**A new round has begun.**")
SEND_SOUND(world, sound('sound/ai/welcome.ogg'))
SEND_SOUND(world, sound('sound/roundstart/addiguana.ogg'))

current_state = GAME_STATE_PLAYING
Master.SetRunLevel(RUNLEVEL_GAME)
Expand Down Expand Up @@ -571,15 +571,12 @@ SUBSYSTEM_DEF(ticker)
update_everything_flag_in_db()
if(!round_end_sound)
round_end_sound = pick(\
'sound/roundend/newroundsexy.ogg',
'sound/roundend/apcdestroyed.ogg',
'sound/roundend/bangindonk.ogg',
'sound/roundend/leavingtg.ogg',
'sound/roundend/its_only_game.ogg',
'sound/roundend/yeehaw.ogg',
'sound/roundend/disappointed.ogg',
'sound/roundend/scrunglartiy.ogg',
'sound/roundend/petersondisappointed.ogg'\
'sound/roundend/deliguana.ogg',
'sound/roundend/undecided.ogg',
'sound/roundend/repair.ogg',
'sound/roundend/boowomp.ogg',
'sound/roundend/shiptestingthursday.ogg',
'sound/roundend/gayrights.ogg'\
)
///The reference to the end of round sound that we have chosen.
var/sound/end_of_round_sound_ref = sound(round_end_sound)
Expand Down
Binary file removed sound/roundend/apcdestroyed.ogg
Binary file not shown.
Binary file removed sound/roundend/bangindonk.ogg
Binary file not shown.
Binary file added sound/roundend/boowomp.ogg
Binary file not shown.
Binary file added sound/roundend/deliguana.ogg
Binary file not shown.
Binary file removed sound/roundend/disappointed.ogg
Binary file not shown.
Binary file added sound/roundend/gayrights.ogg
Binary file not shown.
Binary file removed sound/roundend/its_only_game.ogg
Binary file not shown.
Binary file removed sound/roundend/leavingtg.ogg
Binary file not shown.
Binary file removed sound/roundend/newroundsexy.ogg
Binary file not shown.
Binary file removed sound/roundend/petersondisappointed.ogg
Binary file not shown.
Binary file added sound/roundend/repair.ogg
Binary file not shown.
Binary file removed sound/roundend/scrunglartiy.ogg
Binary file not shown.
Binary file added sound/roundend/shiptestingthursday.ogg
Binary file not shown.
Binary file added sound/roundend/undecided.ogg
Binary file not shown.
Binary file removed sound/roundend/yeehaw.ogg
Binary file not shown.
Binary file added sound/roundstart/addiguana.ogg
Binary file not shown.

0 comments on commit 285b6bd

Please sign in to comment.