Skip to content

Commit

Permalink
reverts enabling debug some extra verbs by default (#3076)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
after feedback from admins, they clog the context menu too much.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
I was not fully considering the context menu and it does bloat it yea.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
admin: reverted filling admin context menus with alot of not useful
stuff by rehiding it behind a toggle.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Sun-Soaked <[email protected]>
  • Loading branch information
FalloutFalcon and Sun-Soaked authored Jun 19, 2024
1 parent 6585fe2 commit 3245fe3
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 23 deletions.
2 changes: 1 addition & 1 deletion code/modules/admin/admin.dm
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@
/datum/admins/proc/podspawn_atom(object as text)
set category = "Event.Spawning"
set desc = "(atom path) Spawn an atom via supply drop"
set name = "Supply drop spawn"
set name = "Podspawn"

if(!check_rights(R_SPAWN))
return
Expand Down
17 changes: 4 additions & 13 deletions code/modules/admin/admin_verbs.dm
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,10 @@ GLOBAL_PROTECT(admin_verbs_debug)
/client/proc/cmd_display_del_log,
/client/proc/cmd_display_init_log,
/client/proc/cmd_display_overlay_log,
/client/proc/cmd_admin_grantfullaccess,
/client/proc/cmd_assume_direct_control, //-errorage
/client/proc/cmd_give_direct_control,
/client/proc/getserverlogs, /*for accessing server logs*/
/client/proc/getcurrentlogs, /*for accessing server logs for the current round*/
/client/proc/restart_controller,
/client/proc/disable_debug_verbs,
/client/proc/enable_debug_verbs,
/client/proc/callproc,
/client/proc/callproc_datum,
/client/proc/SDQL2_query,
Expand Down Expand Up @@ -214,12 +211,6 @@ GLOBAL_PROTECT(admin_verbs_debug)
/datum/admins/proc/overmap_view, /* Opens HTML overmap viewer UI */
/client/proc/toggle_AI_interact, /*toggle admin ability to interact with machines as an AI*/
/client/proc/toggle_cdn,
/client/proc/check_timer_sources,
/client/proc/air_status, //Air things
/client/proc/air_status_loc, //More air things
/client/proc/manipulate_organs,
/client/proc/set_server_fps, //allows you to set the ticklag.
/client/proc/start_singlo,
)
GLOBAL_LIST_INIT(admin_verbs_possess, list(/proc/possess, /proc/release))
GLOBAL_PROTECT(admin_verbs_possess)
Expand Down Expand Up @@ -280,7 +271,7 @@ GLOBAL_LIST_INIT(admin_verbs_hideable, list(
/client/proc/cmd_debug_make_powernets,
/client/proc/cmd_debug_mob_lists,
/client/proc/cmd_debug_del_all,
/client/proc/disable_debug_verbs,
/client/proc/enable_debug_verbs,
/proc/possess,
/proc/release,
/client/proc/reload_admins,
Expand Down Expand Up @@ -313,7 +304,7 @@ GLOBAL_PROTECT(admin_verbs_hideable)
if(rights & R_SERVER)
add_verb(src, GLOB.admin_verbs_server)
if(rights & R_DEBUG)
add_verb(src, list(GLOB.admin_verbs_debug, GLOB.admin_verbs_debug_extra))
add_verb(src, GLOB.admin_verbs_debug)
if(rights & R_POSSESS)
add_verb(src, GLOB.admin_verbs_possess)
if(rights & R_PERMISSIONS)
Expand Down Expand Up @@ -347,7 +338,7 @@ GLOBAL_PROTECT(admin_verbs_hideable)
GLOB.admin_verbs_spawn,
/*Debug verbs added by "show debug verbs"*/
GLOB.admin_verbs_debug_extra,
/client/proc/disable_debug_verbs,
/client/proc/enable_debug_verbs,
/client/proc/readmin
))

Expand Down
12 changes: 6 additions & 6 deletions code/modules/admin/verbs/debug.dm
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ But you can call procs that are of type /mob/living/carbon/human/proc/ for that
*/

/client/proc/air_status_loc()
set category = "Debug"
set category = "Debug.Debug"
set name = "Air Status in Location"
if(!mob)
return
Expand Down Expand Up @@ -185,7 +185,7 @@ But you can call procs that are of type /mob/living/carbon/human/proc/ for that
SSblackbox.record_feedback("tally", "admin_verb", 1, "Make Powernets") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!

/client/proc/cmd_admin_grantfullaccess(mob/M in GLOB.mob_list)
set category = "Debug"
set category = "Debug.Debug"
set name = "Grant Full Access"

if(!SSticker.HasRoundStarted())
Expand Down Expand Up @@ -228,7 +228,7 @@ But you can call procs that are of type /mob/living/carbon/human/proc/ for that
message_admins("<span class='adminnotice'>[key_name_admin(usr)] has granted [M.key] full access.</span>")

/client/proc/cmd_assume_direct_control(mob/M in GLOB.mob_list)
set category = "Debug"
set category = "Debug.Debug"
set name = "Assume direct control"
set desc = "Direct intervention"

Expand All @@ -249,7 +249,7 @@ But you can call procs that are of type /mob/living/carbon/human/proc/ for that
SSblackbox.record_feedback("tally", "admin_verb", 1, "Assume Direct Control") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!

/client/proc/cmd_give_direct_control(mob/M in GLOB.mob_list)
set category = "Debug"
set category = "Debug.Debug"
set name = "Give direct control"

if(!M)
Expand Down Expand Up @@ -530,7 +530,7 @@ But you can call procs that are of type /mob/living/carbon/human/proc/ for that
return dresscode

/client/proc/start_singlo()
set category = "Debug"
set category = "Debug.Debug"
set name = "Start Singularity"
set desc = "Sets up the singularity and all machines to get power flowing through the station"

Expand Down Expand Up @@ -797,7 +797,7 @@ But you can call procs that are of type /mob/living/carbon/human/proc/ for that

/// A debug verb to check the sources of currently running timers
/client/proc/check_timer_sources()
set category = "Debug"
set category = "Debug.Debug"
set name = "Check Timer Sources"
set desc = "Checks the sources of the running timers"
if (!check_rights(R_DEBUG))
Expand Down
2 changes: 1 addition & 1 deletion code/modules/admin/verbs/diagnostics.dm
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/client/proc/air_status(turf/target)
set category = "Debug"
set category = "Debug.Debug"
set name = "Display Air Status"

if(!isturf(target))
Expand Down
2 changes: 1 addition & 1 deletion code/modules/admin/verbs/fps.dm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//replaces the old Ticklag verb, fps is easier to understand
/client/proc/set_server_fps()
set category = "Debug"
set category = "Debug.Debug"
set name = "Set Server FPS"
set desc = "Sets game speed in frames-per-second. Can potentially break the game"

Expand Down
2 changes: 1 addition & 1 deletion code/modules/admin/verbs/manipulate_organs.dm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/client/proc/manipulate_organs(mob/living/carbon/C in world)
set name = "Manipulate Organs"
set category = "Debug"
set category = "Debug.Debug"
var/operation = input("Select organ operation.", "Organ Manipulation", "cancel") as null|anything in list("add organ", "add implant", "drop organ/implant", "remove organ/implant", "cancel")
if (!operation)
return
Expand Down
9 changes: 9 additions & 0 deletions code/modules/admin/verbs/mapping.dm
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ GLOBAL_LIST_INIT(admin_verbs_debug_extra, list(
/client/proc/show_line_profiling,
/client/proc/start_line_profiling,
/client/proc/stop_line_profiling,
/client/proc/check_timer_sources,
/client/proc/air_status, //Air things
/client/proc/air_status_loc, //More air things
/client/proc/manipulate_organs,
/client/proc/set_server_fps, //allows you to set the ticklag.
/client/proc/start_singlo,
/client/proc/cmd_admin_grantfullaccess,
/client/proc/cmd_assume_direct_control, //-errorage
/client/proc/cmd_give_direct_control,
))
GLOBAL_PROTECT(admin_verbs_debug_extra)

Expand Down

0 comments on commit 3245fe3

Please sign in to comment.