Skip to content

Commit

Permalink
Changed portable generator sheet burn times (#2882)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Portable generators all have different burn times. This unifies them.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

The superpacman was actually inferior, and considerably so, to the
regular pacman in total energy generated. A pacman had a time_per_sheet
of 260, while a superpacman was only 85 for only double the power! This
made it inferior in every way, because uranium is also quite rare.

While there are no obtainable mrspacmans as far as I am aware, I find no
reason to have any of these generators set with different burn times.
This simplifies it by unifying all of them into the same base
time_per_sheet of 260.

I am aware this is going to mess with balance a little bit, but I
believe that simplifying the amount of variables in play will help make
balancing easier in the long run, because it isn't immediately obvious
that there were different sheet burn times. Balance should be affected
by changing power generated, uranium spawn rate, number of sheets and
generators at round start... etc, not some property that you can't see
unless you stand there comparing generators side by side.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: All pacman and its variants now have the same sheet burn times.
Superpacmans are no longer the vastly inferior generator.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

Co-authored-by: FalloutFalcon <[email protected]>
  • Loading branch information
Anticept and FalloutFalcon authored May 27, 2024
1 parent 06afcee commit 326791c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions code/modules/power/port_gen.dm
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@
circuit = /obj/item/circuitboard/machine/pacman/super
sheet_path = /obj/item/stack/sheet/mineral/uranium
power_gen = 15000
time_per_sheet = 85

/obj/machinery/power/port_gen/pacman/super/overheat()
. =..()
Expand All @@ -304,7 +303,6 @@
circuit = /obj/item/circuitboard/machine/pacman/mrs
sheet_path = /obj/item/stack/sheet/mineral/diamond
power_gen = 40000
time_per_sheet = 80

/obj/machinery/power/port_gen/pacman/mrs/overheat()
. =..()
Expand Down

0 comments on commit 326791c

Please sign in to comment.