Faction datums for smarter faction logic (#3156)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
A basic datum system for managing factions, currently they are only used
to consistently grab faction names!

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Simplify attaching content to factions.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Added faction datums, this will be cool soon!
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: FalloutFalcon <[email protected]>

_maps/configs/independent_beluga.json

@@ -1,8 +1,12 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Beluga-class Transport",
+	"faction": "/datum/faction/independent",
 	"prefix": "SV",
-	"namelists": ["CRUISE", "NATURAL"],
+	"namelists": [
+		"CRUISE",
+		"NATURAL"
+	],
 	"map_short_name": "Beluga-class",
 	"map_path": "_maps/shuttles/independent/independent_beluga.dmm",
 	"description": "The Beluga-Class is a transport vessel for those with especially rich blood. Featuring a modest kitchen, hired Inteq security, and luxurious decoration, the Beluga is a first choice pick for many wealthy spacers trying to get from point A to B. The independent ship features several rooms for its guests and a well furnished meeting room for any corporate occassion.",

_maps/configs/independent_box.json

@@ -12,6 +12,7 @@
 		"SPACE",
 		"NATURAL"
 	],
+	"faction": "/datum/faction/independent",
 	"prefix": "IMV",
 	"job_slots": {
 		"Chief Medical Officer": {

_maps/configs/independent_bubble.json

@@ -12,6 +12,7 @@
 		"GENERAL",
 		"SPACE"
 	],
+	"faction": "/datum/faction/independent",
 	"prefix": "ISV",
 	"limit": 1,
 	"job_slots": {

_maps/configs/independent_dwayne.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Mark.II Dwayne-class Long Range Mining Transport",
+	"faction": "/datum/faction/independent",
 	"prefix": "SV",
 	"namelists": [
 		"GENERAL",

_maps/configs/independent_junker.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Junker-class Salvaged Ship",
+	"faction": "/datum/faction/independent",
 	"prefix": "SV",
 	"namelists": [
 		"GENERAL",

_maps/configs/independent_kilo.json

@@ -5,6 +5,7 @@
 	"tags": [
 		"Mining"
 	],
+	"faction": "/datum/faction/independent",
 	"prefix": "SV",
 	"namelists": [
 		"GENERAL",

_maps/configs/independent_lagoon.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Lagoon-class Cruise Ship",
+	"faction": "/datum/faction/independent",
 	"prefix": "SV",
 	"description": "An unusual sight in the relatively impoverished Frontier, the Lagoon-class is a large pleasure vessel dedicated to transporting its passengers to any number of exotic locales. Lagoons found on the Frontier tend to contain crews and passengers of a particularly daring – or foolhardy – character, willing to pay out the nose for a tour of some of the most dangerous regions in known space. Accordingly, Lagoons in these regions typically include a small but respectably equipped security contingent to protect (and, when necessary, rein in) the passengers, and come with a surprisingly powerful thermo-electric generator to move the ship’s prodigious bulk across vast expanses of space.",
 	"tags": [

_maps/configs/independent_mudskipper.json

@@ -2,6 +2,7 @@
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Mudskipper-class Salvage Clipper",
 	"map_short_name": "Mudskipper-class",
+	"faction": "/datum/faction/independent",
 	"prefix": "ISV",
 	"description": "One of the cheapest (and yet, inexplicably popular) offerings from Miskilamo Spacefaring, the Mudskipper-class is a vessel purpose-built for enterprising scrappers and looters looking to salvage bombed-out ruins and harvest boatloads of materials. Featuring a diverse set of multipurpose rooms, a charitable supply of EVA/ruin raiding equipment, and a set of anti-radiation gear for dealing with industrial accidents, the Mudskipper-class just keeps on chuggin’!",
 	"tags": [

_maps/configs/independent_rigger.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Riggs-class Sloop",
+	"faction": "/datum/faction/independent",
 	"prefix": "SV",
 	"namelists": [
 		"GENERAL",

_maps/configs/independent_schmiedeberg.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Schmiedeberg-class Pharmacology Ship",
+	"faction": "/datum/faction/independent",
 	"prefix": "IMV",
 	"map_short_name": "Schmiedeberg-class",
 	"description": "Interested in pharmacological science, but tired of sitting in front of a chemistry dispenser and pushing buttons all day? Eager to combine the culinary arts with the narcotic ones? Hoping to combine all of these qualities with the most important activity of all: making fat stacks of dosh? Then the Schmiedeberg-class is for you! Host to a robust ghetto chemistry lab, a high-efficiency botanical set-up and a complete kitchen-and-storefront, the Schmiedeberg is perfect for back-alley chemists and botanists everywhere.",

_maps/configs/independent_shetland.json

@@ -1,5 +1,6 @@
 {
 	"map_name": "Shetland-class Multipurpose Frigate",
+	"faction": "/datum/faction/independent",
 	"prefix": "SV",
 	"namelists": [
 		"GENERAL",

_maps/configs/independent_sunskipper.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Sunskipper-class Culinary Vessel",
+	"faction": "/datum/faction/independent",
 	"prefix": "SV",
 	"namelists": ["CRUISE", "NATURAL"],
 	"map_short_name": "Sunskipper-class",

_maps/configs/independent_tranquility.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Tranquility-class Flying Apartment Complex",
+	"faction": "/datum/faction/independent",
 	"prefix": "SV",
 	"namelists": [
 		"GENERAL",

_maps/configs/inteq_colossus.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Colossus-class Armored Frigate",
+	"faction": "/datum/faction/inteq",
 	"prefix": "IRMV",
 	"description": "The mainstay of Inteq’s mercenary fleet, the Colossus is a professionally-militarized freighter like most of Inteq’s ships, and is designed to operate independently for some time, serving IRMG’s interests and providing vital mercenary services wherever they are needed. Key features include a secure and well-stocked armory and ample crew space, as well as a spacious cargo bay, which crews often refurbish into additional recreational or training space.",
 	"tags": [

_maps/configs/inteq_hound.json

@@ -1,5 +1,6 @@
 {
 	"map_name": "Hound-class Corvette",
+	"faction": "/datum/faction/inteq",
 	"prefix": "IRMV",
 	"namelists": [
 		"MYTHOLOGICAL",

_maps/configs/inteq_talos.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Talos-class Command Clipper",
+	"faction": "/datum/faction/inteq",
 	"prefix": "IRMV",
 	"description": "The Talos is a command and support ship, and a rare example of a purpose-built Inteq ship. Outfitted with an abundance of construction and engineering equipment and a private bluespace communications suite capable of networking IRMG ships across any given system, Taloses are often the lynchpin of coordinated IRMG operations in a system, and offer construction and repair services as part of IRMG’s mercenary offerings. As Talos crews place a larger emphasis on support personnel, they tend to be less well-armed than other Inteq crews. One unusual feature of the Talos is its depressurized “wings” filled with redundant baffles, intended to provide extra durability in the case of impacts or weapons fire. They also double as auxiliary storage space and potential room for modification by their enterprising Artificer crews.",
 	"tags": [

_maps/configs/inteq_valor.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Valor-Class Field Care Cruiser",
+	"faction": "/datum/faction/inteq",
 	"prefix": "IRMV",
 	"description": "The Valor is the dedicated medical vessel of the Inteq fleet, suitable for treatment both for Inteq combat casualties, or paid treatment of outsiders. It's equipped with high-end medical equipment and a small ambulance for patient transport for this purpose.",
 	"tags": ["Medical", "Subshuttle"],

_maps/configs/inteq_vaquero.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Vaquero-class Light Frigate",
+	"faction": "/datum/faction/inteq",
 	"prefix": "IRMV",
 	"description": "The Vaquero is a flexible and cheap military conversion of a light commercial freighter, widely used by Inteq Risk Management Group for picket, reconnaissance, and light escort duty, or for contracts that don't warrant a larger, more specialized ship. Unlike most Inteq ships, the Vaquero features basic medical, engineering, and military equipment all in one package, and its minimal crew requirements are an excellent fit for Vanguards with a smaller command and for training missions. Like its peers, it features a large cargo bay, which can be reconfigured as needed.",
 	"tags": [

_maps/configs/nanotrasen_delta.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Delta-class Frigate",
+	"faction": "/datum/faction/nt/ns_logi",
 	"prefix": "NSSV",
 	"namelists": [
 		"GENERAL",

_maps/configs/nanotrasen_gecko.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Gecko-class Salvage Runner",
+	"faction": "/datum/faction/nt",
 	"prefix": "NTSV",
 	"namelists": [
 		"NANOTRASEN",

_maps/configs/nanotrasen_heron.json

@@ -1,7 +1,10 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
+	"faction": "/datum/faction/nt",
 	"prefix": "NTSV",
-	"namelists": ["WEAPONS"],
+	"namelists": [
+		"WEAPONS"
+	],
 	"map_name": "Heron-Class Dreadnaught",
 	"map_short_name": "Heron-class",
 	"map_path": "_maps/shuttles/nanotrasen/nanotrasen_heron.dmm",
@@ -33,15 +36,15 @@
 			"outfit": "/datum/outfit/job/nanotrasen/security",
 			"slots": 1
 		},
-		"ERT Officer":{
+		"ERT Officer": {
 			"outfit": "/datum/outfit/job/nanotrasen/security/ert",
 			"slots": 4
 		},
-		"ERT Medical Officer":{
+		"ERT Medical Officer": {
 			"outfit": "/datum/outfit/job/nanotrasen/security/ert/med",
 			"slots": 1
 		},
-		"ERT Engineering Officer":{
+		"ERT Engineering Officer": {
 			"outfit": "/datum/outfit/job/nanotrasen/security/ert/engi",
 			"slots": 1
 		},
@@ -53,20 +56,19 @@
 			"outfit": "/datum/outfit/job/nanotrasen/engineer",
 			"slots": 1
 		},
-		"Chief Engineer":{
+		"Chief Engineer": {
 			"outfit": "/datum/outfit/job/nanotrasen/ce",
 			"officer": true,
 			"slots": 1
 		},
 		"Roboticist": {
-			"outfit":"/datum/outfit/job/nanotrasen/roboticist",
+			"outfit": "/datum/outfit/job/nanotrasen/roboticist",
 			"slots": 1
 		},
-		"Medical Doctor":{
+		"Medical Doctor": {
 			"outfit": "/datum/outfit/job/nanotrasen/doctor",
 			"slots": 1
 		},
-
 		"Atmospheric Technician": 1,
 		"Quartermaster": 1,
 		"Cargo Technician": 1,

_maps/configs/nanotrasen_meta.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Meta-class Freighter",
+	"faction": "/datum/faction/nt",
 	"prefix": "NTSV",
 	"map_short_name": "Meta-class",
 	"description": "The Meta-class is a medium freight vessel designed for comfort and sustainability over long journeys of delivering cargo. Most, if not all of these ships are no longer under the direct management of the Company, leaving regulation and professionalism at the behest of individual captains. They can be found running independent contracts, delivering cargo, smuggling illicit goods, and generally trying to stay afloat ever since the collapse of Nanotrasen's operations in the frontier.",

_maps/configs/nanotrasen_mimir.json

@@ -1,5 +1,6 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
+	"faction": "/datum/faction/nt",
 	"prefix": "NTSV",
 	"namelists": [
 		"NANOTRASEN",

_maps/configs/nanotrasen_osprey.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Osprey-class Exploration Cruiser",
+	"faction": "/datum/faction/nt",
 	"prefix": "NTSV",
 	"namelists": [
 		"NANOTRASEN",

_maps/configs/nanotrasen_ranger.json

@@ -1,7 +1,8 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
-	"prefix": "NTSV",
 	"map_name": "Ranger-class Aid Vessel",
+	"faction": "/datum/faction/nt",
+	"prefix": "NTSV",
 	"namelists": [
 		"NANOTRASEN",
 		"NATURAL_AGGRESSIVE",

_maps/configs/nanotrasen_skipper.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Skipper-class Heavy Cruiser",
+	"faction": "/datum/faction/nt",
 	"map_short_name": "Skipper-class",
 	"prefix": "NTSV",
 	"namelists": [

_maps/configs/pgf_crying_sun.json

@@ -1,5 +1,6 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
+	"faction": "/datum/faction/pgf",
 	"prefix": "PGFN",
 	"map_name": "Crying Sun-class Light Frigate",
 	"namelists": [

_maps/configs/pirate_libertatia.json

@@ -7,6 +7,7 @@
 	"tags": [
 		"Combat"
 	],
+	"faction": "/datum/faction/frontier",
 	"prefix": "ISV",
 	"namelists": [
 		"PIRATES",

_maps/configs/pirate_noderider.json

@@ -2,6 +2,7 @@
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Jupiter-class Stormrider",
 	"map_short_name": "Jupiter-class",
+	"faction": "/datum/faction/frontier",
 	"prefix": "ISV",
 	"namelists": [
 		"INSTALLATION",

_maps/configs/pirate_tortuga.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Tortuga-class Converted Cargo Freighter",
+	"faction": "/datum/faction/frontier",
 	"prefix": "ISV",
 	"namelists": [
 		"PIRATES",

_maps/configs/solgov_chronicle.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Chronicle-class Sensor Frigate",
+	"faction": "/datum/faction/solgov",
 	"prefix": "SCSV",
 	"namelists": [
 		"SOLGOV",

_maps/configs/solgov_inkwell.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Inkwell-class Supply Freighter",
+	"faction": "/datum/faction/solgov",
 	"prefix": "SCSV",
 	"namelists": [
 		"SOLGOV",

_maps/configs/solgov_paracelsus.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Paracelsus-class Medical Corvette",
+	"faction": "/datum/faction/solgov",
 	"prefix": "SCSV",
 	"namelists": [
 		"SOLGOV",

_maps/configs/srm_elder.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Elder-class Montagnes' Vessel",
+	"faction": "/datum/faction/srm",
 	"prefix": "SRSV",
 	"namelists": [
 		"SAINT-ROUMAIN",

_maps/configs/syndicate_cybersun_kansatsu.json

@@ -1,5 +1,6 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
+	"faction": "/datum/faction/syndicate/cybersun",
 	"prefix": "CSSV",
 	"namelists": [
 		"CYBERSUN",

_maps/configs/syndicate_gorlex_hyena.json

@@ -1,5 +1,6 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
+	"faction": "/datum/faction/syndicate/ngr",
 	"prefix": "NGRV",
 	"namelists": [
 		"GORLEX",

_maps/configs/syndicate_gorlex_komodo.json

@@ -1,4 +1,5 @@
 {
+	"faction": "/datum/faction/syndicate",
 	"prefix": "ISV",
 	"namelists": [
 		"GORLEX",

_maps/configs/syndicate_litieguai.json

@@ -1,6 +1,7 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Li Tieguai-class Rescue Ship",
+	"faction": "/datum/faction/syndicate/cybersun",
 	"prefix": "CSSV",
 	"map_short_name": "Li Tieguai-class",
 	"description": "A small, nimble, and exceptionally well-built medical response vessel, the Li Tieguai is a recent addition to Cybersun’s fleet, forming a critical component of their Frontier stabilization program. Li Tieguais come equipped with high-end medical equipment, including a selection of Cybersun augments and prosthetics, as well as weaponry and armor sufficient to protect its personnel in the often-dangerous Frontier sectors, so that they can offer premium healthcare (at premium prices) in even the most dangerous of scenarios.",

_maps/configs/syndicate_twinkleshine.json

@@ -1,5 +1,6 @@
 {
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
+	"faction": "/datum/faction/syndicate",
 	"prefix": "SSV",
 	"namelists": [
 		"GORLEX",

_maps/example_ship_config.json

@@ -2,6 +2,7 @@
 	"$schema": "https://raw.githubusercontent.com/shiptest-ss13/Shiptest/master/_maps/ship_config_schema.json",
 	"map_name": "Example-class Experimental Ship",
 	"map_short_name": "Test-class",
+	"faction": "/datum/faction/independent",
 	"prefix": "STSV",
 	"namelists": ["GENERAL", "SPACE", "MYTHOLOGICAL", "WEAPONS"],
 	"map_path": "_maps/shuttles/shiptest/null.dmm",

_maps/ship_config_schema.json

@@ -28,17 +28,17 @@
 			"type": "array",
 			"description": "A list of tags describing the ship's niche, converted into searchable strings."
 		},
+		"faction": {
+			"title": "Ship Faction Datum",
+			"type": [ "null", "string" ],
+			"description": "Default faction datum"
+		},
 		"prefix": {
 			"title": "Ship Default Prefix",
 			"type": [ "null", "string" ],
 			"description": "The prefix of the ship class, appended to randomly generated names when they're first purchased.",
 			"maxLength": 5
 		},
-		"faction_name": {
-			"title": "Faction Name",
-			"type": [ "null", "string" ],
-			"description": "A custom faction name for the ship class. If exluded or left blank, the ship will use the default faction name for the faction that matches the ship's prefix."
-		},
 		"namelists": {
 			"title": "Namelists",
 			"type": "array",

check_regex.yaml

@@ -31,7 +31,7 @@ standards:
     - exactly: [4, "/mob text paths", '"/mob']
     - exactly: [43, "/obj text paths", '"/obj']
     - exactly: [0, "/turf text paths", '"/turf']
-    - exactly: [116, "text2path uses", "text2path"]
+    - exactly: [117, "text2path uses", "text2path"]
 
     - exactly: [18, "world<< uses", 'world[ \t]*<<']
     - exactly: [0, "world.log<< uses", 'world.log[ \t]*<<']