Skip to content

Commit

Permalink
Ports the Requests Manager, Minor Fax QOL, Adds factional offices to …
Browse files Browse the repository at this point in the history
…CentCom (#2653)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
This pull requests ports:
* BeeStation/BeeStation-Hornet#9408
* BeeStation/BeeStation-Hornet#9236
This pull request reverts:
* tgstation/tgstation#70072

The requests manager is now a thing.

![264860380-6d27a710-8ac1-4864-9abe-4c13f4885cba](https://github.com/shiptest-ss13/Shiptest/assets/75212565/dc3277d3-9770-4450-97a8-6b4b918cf25b)

It also adds little offices with fax machines for factions to CentCom,
which recieve the physical paper and can send faxes back (though admins
can still make use of the fax panel).

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/1abb223f-1914-4ab9-8240-e2969a4e47f5)
They can also fax each other, if ever needed.

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/1d551e8e-cbea-4116-a608-f319411484b6)


<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
* Gives admins the ability to see a very easy to use recap of all
requests that occur in a round. This system is readily extendible to
support other types of requests, should someone care to add it.
* Better admin tools, admins can now send faxes directly via the new Fax
Manager verb, and faxes are show in the request panel instead of its own
panel.
* You can now LARP as a Cybersun minimum wage intern handling faxes.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: bobbahbrown, itsmeow, meemofcourse
add: CentCom now has some small offices, which recieve physical faxes.
add: Fax machines now announce that they have received a fax over radio.
add: Fax machines announce important faxes VERY LOUDLY.
balance: Faxes no longer require a subspace ansible crystal.
code: Faxes now use typepath instead of varedit.
tweak: Changed how special/faction faxes work. Login is no longer
required to use special faxes.
admin: Add Requests Manager to view all fax messages/prayers/centcom and
syndicate requests/and nuke code requests within a round.
admin: Removed old fax manager in favor of Requests Manager, added "Send
Fax Message" verb to send admin faxes via a menu.
fix: Fixed runtime when ghosts tried to view paper.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
meemofcourse authored Feb 2, 2024
1 parent 05e51b4 commit 878a80d
Show file tree
Hide file tree
Showing 33 changed files with 2,546 additions and 1,078 deletions.
2 changes: 1 addition & 1 deletion _maps/RandomRuins/JungleRuins/jungle_cavecrew.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -3119,7 +3119,7 @@
/obj/structure/table/reinforced{
color = "#c1b6a5"
},
/obj/machinery/fax/frontiersmen,
/obj/machinery/fax/ruin,
/turf/open/floor/plasteel/tech,
/area/ruin/jungle/cavecrew/bridge)
"Ls" = (
Expand Down
2 changes: 1 addition & 1 deletion _maps/RandomRuins/JungleRuins/jungle_syndicate.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -1330,7 +1330,7 @@
"OW" = (
/obj/structure/table/reinforced,
/obj/item/trash/syndi_cakes,
/obj/machinery/fax,
/obj/machinery/fax/ruin,
/turf/open/floor/plating,
/area/ruin/jungle/syndifort/jerry)
"Ph" = (
Expand Down
2 changes: 1 addition & 1 deletion _maps/RandomRuins/SpaceRuins/corporate_mining.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,7 @@
/area/ruin/space)
"xK" = (
/obj/structure/table/wood,
/obj/machinery/fax,
/obj/machinery/fax/ruin,
/turf/open/floor/wood,
/area/ruin/space/has_grav/corporatemine/crewquarters)
"xT" = (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@
/area/ruin/powered)
"dT" = (
/obj/structure/table/wood,
/obj/machinery/fax,
/obj/machinery/fax/ruin,
/turf/open/floor/plating,
/area/ruin/powered)
"dU" = (
Expand Down
Loading

0 comments on commit 878a80d

Please sign in to comment.