Skip to content

Commit

Permalink
Fixes inconsistent list syntax in set_status_tab (#74079)
Browse files Browse the repository at this point in the history
BYOND is inconsistent about whether it treats these as `"key" = value`,
or `src.key = value`, or something else. We suspect that this behavior
is fluctuating in 515, and given that this proc has been causing immense
overtime, that it might be the culprit of some recent complains of
recurring lag. And if it's not, then we at least have more consistent
code.
  • Loading branch information
Mothblocks authored and MarkSuckerberg committed Dec 11, 2023
1 parent 1745367 commit 8b74574
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions code/controllers/subsystem/statpanel.dm
Original file line number Diff line number Diff line change
Expand Up @@ -92,17 +92,17 @@ SUBSYSTEM_DEF(statpanels)
return

target.stat_panel.send_message("update_stat", list(
global_data = global_data,
ping_str = "Ping: [round(target.lastping, 1)]ms (Average: [round(target.avgping, 1)]ms)",
other_str = target.mob?.get_status_tab_items(),
"global_data" = global_data,
"ping_str" = "Ping: [round(target.lastping, 1)]ms (Average: [round(target.avgping, 1)]ms)",
"other_str" = target.mob?.get_status_tab_items(),
))

/datum/controller/subsystem/statpanels/proc/set_MC_tab(client/target)
var/turf/eye_turf = get_turf(target.eye)
var/coord_entry = COORD(eye_turf)
if(!mc_data)
generate_mc_data()
target.stat_panel.send_message("update_mc", list(mc_data = mc_data, coord_entry = coord_entry))
target.stat_panel.send_message("update_mc", list("mc_data" = mc_data, "coord_entry" = coord_entry))

/datum/controller/subsystem/statpanels/proc/set_tickets_tab(client/target)
var/list/ahelp_tickets = GLOB.ahelp_tickets.stat_entry()
Expand Down

0 comments on commit 8b74574

Please sign in to comment.