Skip to content

Commit

Permalink
Replace nearly every map grep with a YML file that actually respects …
Browse files Browse the repository at this point in the history
…structure, and fixes the massive amount of failures that were never caught (#72372)

[Documentation
here](https://github.com/Mothblocks/tgstation/blob/maplint/tools/maplint/README.md)

We should not be using greps to the capacity that we currently are. If
you are not smarter than a parser, then you should not try to beat one.
DMM files should NOT be treated as text files that can be parsed with
any old Unix tool. They are a structured language. Because of our abuse
of greps, check_greps is full of hard to read, hard to maintain checks
that do not consistently work, because they all make very specific
assumptions about how TGM works, which are provably untrue.

This format is mostly straightforward for the lints people write, and
easily extensible to the ones people will want to write.

:cl:
fix: Fixes a bunch of cases of windows not being where they were
supposed to be, tables/chairs stacking on each other, and other very
small stuff you've never noticed before.
/:cl:
  • Loading branch information
Mothblocks authored and MarkSuckerberg committed Oct 25, 2023
1 parent 1aa97c5 commit 9412b8f
Show file tree
Hide file tree
Showing 63 changed files with 880 additions and 84,288 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci_suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
run_linters:
name: Run Linters
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -41,6 +41,7 @@ jobs:
tools/bootstrap/python -c ''
- name: Run Linters
run: |
tools/bootstrap/python -m tools.maplint.source
tools/build/build --ci lint tgui-test
bash tools/ci/check_filedirs.sh shiptest.dme
bash tools/ci/check_changelogs.sh
Expand Down
3 changes: 0 additions & 3 deletions _maps/RandomRuins/BeachRuins/beach_crashed_engineer.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -663,9 +663,6 @@
/turf/open/water/beach,
/area/overmap_encounter/planetoid/beachplanet/explored)
"BF" = (
/obj/structure/cable{
icon_state = "4-8"
},
/obj/structure/cable{
icon_state = "4-8"
},
Expand Down
3 changes: 1 addition & 2 deletions _maps/RandomRuins/SpaceRuins/hellfactory.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,7 @@
/turf/open/floor/plating,
/area/ruin/space/has_grav/hellfactory)
"bb" = (
/obj/structure/window/reinforced/fulltile,
/obj/structure/grille,
/obj/effect/spawner/structure/window/reinforced,
/turf/open/floor/plating,
/area/ruin/space/has_grav/hellfactory)
"bc" = (
Expand Down
Loading

0 comments on commit 9412b8f

Please sign in to comment.