fix a few easy to spot hard deletes (#2580)

shiptest-ss13 · Dec 10, 2023 · be9299a · be9299a
1 parent 9c6031d
commit be9299a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/code/game/machinery/computer/crew.dm b/code/game/machinery/computer/crew.dm
@@ -44,6 +44,10 @@ GLOBAL_DATUM_INIT(crewmonitor, /datum/crewmonitor, new)
 		ui = new(user, src, "CrewConsole")
 		ui.open()
 
+/datum/crewmonitor/ui_close(mob/user)
+	ui_sources -= user
+	return ..()
+
 /datum/crewmonitor/proc/show(mob/M, source)
 	ui_sources[M] = source
 	ui_interact(M)

diff --git a/code/modules/mob/living/silicon/ai/ai.dm b/code/modules/mob/living/silicon/ai/ai.dm
@@ -711,7 +711,7 @@
 
 		for (var/obj/machinery/camera/C in lit_cameras)
 			C.set_light(0)
-			lit_cameras = list()
+		lit_cameras = list()
 
 		return
 
@@ -737,9 +737,15 @@
 	for (var/obj/machinery/camera/C in remove)
 		lit_cameras -= C //Removed from list before turning off the light so that it doesn't check the AI looking away.
 		C.Togglelight(0)
+		UnregisterSignal(C, COMSIG_PARENT_QDELETING, PROC_REF(camera_deleted))
 	for (var/obj/machinery/camera/C in add)
 		C.Togglelight(1)
 		lit_cameras |= C
+		RegisterSignal(C, COMSIG_PARENT_QDELETING, PROC_REF(camera_deleted))
+
+/mob/living/silicon/ai/proc/camera_deleted(obj/machinery/camera/camera)
+	SIGNAL_HANDLER
+	lit_cameras -= camera
 
 /mob/living/silicon/ai/proc/control_integrated_radio()
 	set name = "Transceiver Settings"

diff --git a/code/modules/overmap/ships/controlled_ship_datum.dm b/code/modules/overmap/ships/controlled_ship_datum.dm
@@ -116,6 +116,7 @@
 	. = ..()
 	SSovermap.controlled_ships -= src
 	helms.Cut()
+	QDEL_LIST(missions)
 	LAZYCLEARLIST(owner_candidates)
 	if(!QDELETED(shuttle_port))
 		shuttle_port.current_ship = null

diff --git a/code/modules/vehicles/scooter.dm b/code/modules/vehicles/scooter.dm
@@ -76,7 +76,7 @@
 /obj/vehicle/ridden/scooter/skateboard/Destroy()
 	if(sparks)
 		QDEL_NULL(sparks)
-	. = ..()
+	return ..()
 
 /obj/vehicle/ridden/scooter/skateboard/relaymove(mob/living/user, direction)
 	if (grinding || world.time < next_crash)